-
Notifications
You must be signed in to change notification settings - Fork 296
[DOC] Set strict export explicitly for API change #2430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2430
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @CuiYifeng! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
c6c6bf2
to
5536bf3
Compare
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@ZhiweiYan-96 Please help review, thanks. |
@leslie-fang-intel Could you please have a look? |
@pytorchbot label "ciflow/xpu" |
To add these label(s) (ciflow/xpu) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page). This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
@jerryzh168 @svekars Since old doc is deprecated pytorch/tutorials#3432, could you help review this PR? |
pytorch/pytorch#148790 and pytorch/pytorch#150941 flip the default value of strict argument in
torch.export.export
andtorch.export.export_for_training
from True to False. The workflow of PT2E CPU/XPU has been broken by this API change.This PR is to fix documents with setting
strict=True
explicitly.