Skip to content

Move CUTLASS pin to v3.9.0 #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

Move CUTLASS pin to v3.9.0 #2136

merged 1 commit into from
May 1, 2025

Conversation

alexsamardzic
Copy link
Collaborator

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2136

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit daddb71 with merge base f343336 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 26, 2025
@alexsamardzic alexsamardzic requested a review from drisspg April 26, 2025 11:04
@alexsamardzic alexsamardzic added topic: not user facing Use this tag if you don't want this PR to show up in release notes topic: for developers Use this tag if this PR is mainly developer facing labels Apr 26, 2025
@drisspg
Copy link
Contributor

drisspg commented Apr 26, 2025

The block scaled kernel needs an update

drisspg/driss_torch@c5177a3

@alexsamardzic
Copy link
Collaborator Author

The block scaled kernel needs an update

drisspg/driss_torch@c5177a3

Where is this file?

@drisspg
Copy link
Contributor

drisspg commented Apr 26, 2025

ao/torchao/csrc/cuda/mx_kernels/mx_fp_cutlass_kernels.cu

Line 110 in f343336

using Sm100BlkScaledConfig = typename Gemm::GemmKernel::CollectiveMainloop::Sm100BlkScaledConfig;

@alexsamardzic alexsamardzic force-pushed the update-cutlass-to-v3.9.0 branch from 6969109 to daddb71 Compare April 28, 2025 13:30
@alexsamardzic
Copy link
Collaborator Author

Got it, added the change you pointed to to this PR - would that do?

@henrylhtsang
Copy link

Ok I might need this like today

@drisspg drisspg merged commit 12467d2 into pytorch:main May 1, 2025
18 checks passed
@henrylhtsang henrylhtsang mentioned this pull request May 1, 2025
Closed
@alexsamardzic alexsamardzic deleted the update-cutlass-to-v3.9.0 branch May 1, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drisspg drisspg drisspg approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: for developers Use this tag if this PR is mainly developer facing topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexsamardzic @drisspg @henrylhtsang @facebook-github-bot