Skip to content

Remove libOMP linking for experimental kernels #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Remove libOMP linking for experimental kernels #1822

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eeb7648
Remove libOMP lnking for experimental kernels
Jack-Khuu Mar 4, 2025
6bf760e
Install nightly instead of pinned version
Jack-Khuu Mar 4, 2025
e122fd5
Update torchao_experimental_test.yml
Jack-Khuu Mar 4, 2025
a48dbe3
CPUOffload: only offload parameters above a certain size (#1720)
ngc92 Mar 4, 2025
6e988bb
update typehint (#1740)
crcrpar Mar 4, 2025
51e359a
Move torchao/_models to benchmarks/_models (#1784)
jainapurva Mar 4, 2025
b4b5a5e
roofline estimator: add float8 rowwise and mxfp8 recipe support (#1789)
vkuzo Mar 4, 2025
3f24e0c
metal lowbit ops: ci (#1825)
manuelcandales Mar 4, 2025
9322ee1
Fix experimental CI (#1827)
metascroy Mar 4, 2025
28ccd73
Optionally enable KleidiAI + clean up setup.py flags (#1826)
metascroy Mar 4, 2025
e040fb6
Update install instructions
Jack-Khuu Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/torchao_experimental_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Install requirements
run: |
conda activate venv
pip install --extra-index-url "https://download.pytorch.org/whl/nightly/cpu" torch=="2.6.0.dev20250104"
pip install --extra-index-url "https://download.pytorch.org/whl/nightly/cpu"
pip install numpy
pip install pytest
USE_CPP=1 pip install .
Expand Down
1 change: 0 additions & 1 deletion torchao/experimental/Utils.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ function(target_link_torchao_parallel_backend target_name torchao_parallel_backe
target_link_libraries(${target_name} PRIVATE "${TORCH_LIBRARIES}")

target_compile_definitions(${target_name} PRIVATE TORCHAO_PARALLEL_ATEN=1 AT_PARALLEL_OPENMP=1 INTRA_OP_PARALLEL=1)
target_link_libraries(${target_name} PRIVATE ${TORCH_INSTALL_PREFIX}/lib/libomp${CMAKE_SHARED_LIBRARY_SUFFIX})

elseif(TORCHAO_PARALLEL_BACKEND_TOUPPER STREQUAL "EXECUTORCH")
message(STATUS "Building with TORCHAO_PARALLEL_BACKEND=TORCHAO_PARALLEL_EXECUTORCH")
Expand Down
Loading