zero dim support for tensorwise float8 training #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1352
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 2e5001e with merge base a558f7e ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vkuzo
force-pushed
the
20241118_zero_dim
branch
2 times, most recently
from
f2e4d5f to
a9ec849
Compare
vkuzo
changed the title
vkuzo
force-pushed
the
20241118_zero_dim
branch
from
a9ec849 to
a130365
Compare
drisspg
approved these changes
Nov 26, 2024
vkuzo
added
the
topic: improvement
vkuzo
changed the title
vkuzo
force-pushed
the
20241118_zero_dim
branch
from
a130365 to
b8b4601
Compare
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
vkuzo
force-pushed
the
20241118_zero_dim
branch
from
b8b4601 to
2e5001e
Compare
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
…resses ctrl+c (pytorch#1352) Setup a SIGINT handler to gracefully exit the program once the user presses ctrl+c. Signed-off-by: Sébastien Han <seb@redhat.com> Co-authored-by: Jack-Khuu <jack.khuu.7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a test for zero-dim support for tensorwise scaling for float8 training. Doing tensorwise-only for now to unblock a customer. We'll follow up with rowwise/blockwise in future PRs.
Requires pytorch/pytorch#140967
Test Plan: CI
Reviewers:
Subscribers:
Tasks:
Tags: