Fix scaled_mm_rowwise in quantize_bench #4551
Closed
+30
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D78844879 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cthi
added a commit
to cthi/FBGEMM-1
that referenced
this pull request
Jul 24, 2025
Summary: X-link: facebookresearch/FBGEMM#1594 When looking at this with samanamp recently I noticed the scaled_mm is not actually using the rowwise scaling with it, I think this was before it was supported properly. We also add support for compile, which will be useful for testing. Reviewed By: jianyuh Differential Revision: D78844879
cthi
added a commit
to cthi/FBGEMM-1
that referenced
this pull request
Jul 24, 2025
Summary: X-link: facebookresearch/FBGEMM#1594 When looking at this with samanamp recently I noticed the scaled_mm is not actually using the rowwise scaling with it, I think this was before it was supported properly. We also add support for compile, which will be useful for testing. Reviewed By: jianyuh Differential Revision: D78844879
cthi
force-pushed
the
export-D78844879
branch
2 times, most recently
from
ee532a8 to
5964585
Compare
cthi
added a commit
to cthi/FBGEMM-1
that referenced
this pull request
Jul 24, 2025
Summary: X-link: facebookresearch/FBGEMM#1594 When looking at this with samanamp recently I noticed the scaled_mm is not actually using the rowwise scaling with it, I think this was before it was supported properly. We also add support for compile, which will be useful for testing. Reviewed By: jianyuh Differential Revision: D78844879
cthi
added a commit
to cthi/FBGEMM-1
that referenced
this pull request
Jul 24, 2025
Summary: X-link: facebookresearch/FBGEMM#1594 When looking at this with samanamp recently I noticed the scaled_mm is not actually using the rowwise scaling with it, I think this was before it was supported properly. We also add support for compile, which will be useful for testing. Reviewed By: jianyuh Differential Revision: D78844879
|
This pull request was exported from Phabricator. Differential Revision: D78844879 |
cthi
added a commit
to cthi/FBGEMM-1
that referenced
this pull request
Jul 24, 2025
Summary: Pull Request resolved: pytorch#4551 X-link: facebookresearch/FBGEMM#1594 When looking at this with samanamp recently I noticed the scaled_mm is not actually using the rowwise scaling with it, I think this was before it was supported properly. We also add support for compile, which will be useful for testing. Reviewed By: jianyuh Differential Revision: D78844879
cthi
added a commit
to cthi/FBGEMM-1
that referenced
this pull request
Jul 24, 2025
Summary: X-link: facebookresearch/FBGEMM#1594 When looking at this with samanamp recently I noticed the scaled_mm is not actually using the rowwise scaling with it, I think this was before it was supported properly. We also add support for compile, which will be useful for testing. Reviewed By: jianyuh Differential Revision: D78844879
|
This pull request was exported from Phabricator. Differential Revision: D78844879 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D78844879 |
cthi
added a commit
to cthi/FBGEMM-1
that referenced
this pull request
Jul 24, 2025
Summary: Pull Request resolved: pytorch#4551 X-link: facebookresearch/FBGEMM#1594 When looking at this with samanamp recently I noticed the scaled_mm is not actually using the rowwise scaling with it, I think this was before it was supported properly. We also add support for compile, which will be useful for testing. Reviewed By: jianyuh Differential Revision: D78844879
|
This pull request was exported from Phabricator. Differential Revision: D78844879 |
cthi
added a commit
to cthi/FBGEMM-1
that referenced
this pull request
Jul 24, 2025
Summary: Pull Request resolved: pytorch#4551 X-link: facebookresearch/FBGEMM#1594 When looking at this with samanamp recently I noticed the scaled_mm is not actually using the rowwise scaling with it, I think this was before it was supported properly. We also add support for compile, which will be useful for testing. Reviewed By: jianyuh Differential Revision: D78844879
Summary: Pull Request resolved: pytorch#4551 X-link: facebookresearch/FBGEMM#1594 When looking at this with samanamp recently I noticed the scaled_mm is not actually using the rowwise scaling with it, I think this was before it was supported properly. We also add support for compile, which will be useful for testing. Reviewed By: jianyuh Differential Revision: D78844879
|
This pull request was exported from Phabricator. Differential Revision: D78844879 |
|
This pull request has been merged in f509911. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1594
When looking at this with samanamp recently I noticed the scaled_mm is not actually using the rowwise scaling with it, I think this was before it was supported properly.
We also add support for compile, which will be useful for testing.
Differential Revision: D78844879