Typo and small fixes to CK fp8 rowwise grouped #4550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D78827450 |
cthi
added a commit
to cthi/FBGEMM-1
that referenced
this pull request
Jul 23, 2025
Summary: X-link: facebookresearch/FBGEMM#1593 - Typos+grammar fix found by LLM - Validation bug found by LLM - Small logic simplification I missed in my prior PR. Differential Revision: D78827450
cthi
added a commit
to cthi/FBGEMM-1
that referenced
this pull request
Jul 23, 2025
Summary: X-link: facebookresearch/FBGEMM#1593 - Typos+grammar fix found by LLM - Validation bug found by LLM - Small logic simplification I missed in my prior PR. Differential Revision: D78827450
cthi
force-pushed
the
export-D78827450
branch
2 times, most recently
from
2b9b8c2 to
cda3b0b
Compare
cthi
added a commit
to cthi/FBGEMM-1
that referenced
this pull request
Jul 23, 2025
Summary: X-link: facebookresearch/FBGEMM#1593 - Typos+grammar fix found by LLM - Validation bug found by LLM - Small logic simplification I missed in my prior PR. Differential Revision: D78827450
|
This pull request was exported from Phabricator. Differential Revision: D78827450 |
cthi
added a commit
to cthi/FBGEMM-1
that referenced
this pull request
Jul 23, 2025
Summary: X-link: facebookresearch/FBGEMM#1593 - Typos+grammar fix found by LLM - Validation bug found by LLM - Small logic simplification I missed in my prior PR. Differential Revision: D78827450
cthi
added a commit
to cthi/FBGEMM-1
that referenced
this pull request
Jul 23, 2025
Summary: X-link: facebookresearch/FBGEMM#1593 - Typos+grammar fix found by LLM - Validation bug found by LLM - Small logic simplification I missed in my prior PR. Differential Revision: D78827450
|
This pull request was exported from Phabricator. Differential Revision: D78827450 |
cthi
added a commit
to cthi/FBGEMM-1
that referenced
this pull request
Jul 23, 2025
Summary: Pull Request resolved: pytorch#4550 X-link: facebookresearch/FBGEMM#1593 - Typos+grammar fix found by LLM - Validation bug found by LLM - Small logic simplification I missed in my prior PR. Differential Revision: D78827450
Summary: Pull Request resolved: pytorch#4550 X-link: facebookresearch/FBGEMM#1593 - Typos+grammar fix found by LLM - Validation bug found by LLM - Small logic simplification I missed in my prior PR. Differential Revision: D78827450
|
This pull request was exported from Phabricator. Differential Revision: D78827450 |
|
This pull request has been merged in efd564c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1593
Differential Revision: D78827450