Fix pid_m calculation #4539
Open
Fix pid_m calculation #4539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When calculating current pid_m, pid should be first mode by width, then by group_size, not directly by group_size. Assume we have: - grid_m = 5 - grid_n = 5 - group_m = 3 Then for pid 15, the corresponding pid_m should be 4. However, following the current logic that ``` id_m = group_id * GROUP_M + (pid % group_size) ``` pid_m = 1 * 3 + (15%2) = 3+1 = 4 !? Differential Revision: D78712591
|
This pull request was exported from Phabricator. Differential Revision: D78712591 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When calculating current pid_m, pid should be first mode by width, then by group_size, not directly by group_size.
Assume we have:
Then for pid 15, the corresponding pid_m should be 4.
However, following the current logic that
pid_m = 1 * 3 + (15%2) = 3+1 = 4 !?
Differential Revision: D78712591