Skip to content

Don't use deprecated asmjit templates #4481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Jul 13, 2025

Clean up these deprecation warnings before it is possible to build newer asmjit.

Copy link

netlify bot commented Jul 13, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit daf7668
🔍 Latest deploy log https://app.netlify.com/projects/pytorch-fbgemm-docs/deploys/6875d5672d25e000087a792a
😎 Deploy Preview https://deploy-preview-4481--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this in D78252575.

@cyyever
Copy link
Contributor Author

cyyever commented Jul 14, 2025

@q10 gtest also failed because of deprecated functions, now it is fixed.

@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this in D78252575.

cyyever added 3 commits July 15, 2025 09:18
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
@cyyever
Copy link
Contributor Author

cyyever commented Jul 15, 2025

@q10 I disable another warning on MacOS CLAPACK. Since FBGEMM doesn't build on Apple Silicon (for no AVX512), I temporarily disable it. Will recheck the decision later when I can build it on M2.

@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this in D78252575.

Signed-off-by: cyy <cyyever@outlook.com>
@cyyever
Copy link
Contributor Author

cyyever commented Jul 15, 2025

@q10 Let's restore the option but keep the source code changes because I don't have Intel Macbook at hand..

@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this in D78252575.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants