Enable bugprone, misc and readability checks of tidy #4479
Closed
+275
−289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cyy <cyyever@outlook.com>
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cyyever
force-pushed
the
more_warnings
branch
11 times, most recently
from
e21515a to
f7e86e1
Compare
cyyever
force-pushed
the
more_warnings
branch
3 times, most recently
from
99f26eb to
1716347
Compare
cyyever
changed the title
|
@q10 I have added back |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Jul 14, 2025
Summary: X-link: facebookresearch/FBGEMM#1540 The PR adds more clang-tidy checks and fixes most warnings in source files. Pull Request resolved: pytorch#4479 Reviewed By: cthi Differential Revision: D78252587 Pulled By: q10
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Jul 14, 2025
Summary: Pull Request resolved: pytorch#4488 X-link: facebookresearch/FBGEMM#1540 The PR adds more clang-tidy checks and fixes most warnings in source files. Pull Request resolved: pytorch#4479 Reviewed By: cthi Differential Revision: D78252587 Pulled By: q10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds more clang-tidy checks and fixes most warnings in source files.