Skip to content

[BE] Refactor: Modularize extract_source_mappings.py for improved maintainability #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 120 additions & 0 deletions tritonparse/event_diff.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
import json
from collections import defaultdict
from typing import Any, Dict, List, Tuple

from .sourcemap_utils import _flatten_dict, _to_ranges, _unflatten_dict

# Fields that are expected to vary but are not useful to list out in the diff.
SUMMARY_FIELDS = ["pid", "timestamp", "stream", "function", "data_ptr"]


def _generate_launch_diff(
launches: List[Tuple[Dict[str, Any], int]],
) -> Tuple[Dict[str, Any], Dict[str, Any], List[Dict[str, int]]]:
"""
Compares a list of launch events and returns sames, diffs, and an index map.
"""
if not launches:
return {}, {}, []

launch_events = [launch[0] for launch in launches]
launch_index_map = [launch[1] for launch in launches]

if len(launch_events) == 1:
return (
_unflatten_dict(_flatten_dict(launch_events[0])),
{},
_to_ranges(launch_index_map),
)

# Group values by key
data_by_key = defaultdict(lambda: defaultdict(list))
for i, launch in enumerate(launch_events):
launch_flat = _flatten_dict(launch)
for key, value in launch_flat.items():
# JSON doesn't support all Python types as values directly, str is safer
value_str = json.dumps(value, sort_keys=True)
data_by_key[key][value_str].append(i)

sames_flat = {}
diffs_flat = {}

for key, value_groups in data_by_key.items():
if len(value_groups) == 1:
# This key has the same value across all launches
value_str = list(value_groups.keys())[0]
sames_flat[key] = json.loads(value_str)
else:
# This key has different values
is_summary = any(summary_key in key for summary_key in SUMMARY_FIELDS)
if is_summary:
diffs_flat[key] = {
"diff_type": "summary",
"summary_text": f"Varies across {len(value_groups)} unique values",
}
else:
values_dist = []
for value_str, indices in value_groups.items():
values_dist.append(
{
"value": json.loads(value_str),
"count": len(indices),
"launches": _to_ranges(indices),
}
)
# Sort by first occurrence
values_dist.sort(key=lambda x: x["launches"][0]["start"])
diffs_flat[key] = {
"diff_type": "distribution",
"values": values_dist,
}

# Unflatten the results
sames_unflattened = _unflatten_dict(sames_flat)
diffs_unflattened = _unflatten_dict(diffs_flat)

# Special handling for extracted_args to create argument_diff structures
if "extracted_args" in sames_unflattened or "extracted_args" in diffs_unflattened:
sames_args = sames_unflattened.pop("extracted_args", {})
diffs_args_flat = diffs_unflattened.pop("extracted_args", {})

all_arg_names = set(sames_args.keys()) | set(diffs_args_flat.keys())

final_arg_diffs = {}

for arg_name in all_arg_names:
if arg_name in diffs_args_flat:
# This argument has at least one differing sub-field.
arg_sames = {}
arg_diffs_internal = {}

# Collect all sub-fields for this argument from the original data
all_sub_fields = set()
for launch in launch_events:
arg_data = launch.get("extracted_args", {}).get(arg_name, {})
all_sub_fields.update(arg_data.keys())

for sub_field in all_sub_fields:
flat_key = f"extracted_args.{arg_name}.{sub_field}"
if flat_key in diffs_flat:
arg_diffs_internal[sub_field] = diffs_flat[flat_key]
elif flat_key in sames_flat:
arg_sames[sub_field] = sames_flat[flat_key]

if arg_sames or arg_diffs_internal:
final_arg_diffs[arg_name] = {
"diff_type": "argument_diff",
"sames": arg_sames,
"diffs": arg_diffs_internal,
}
elif arg_name in sames_args:
# This argument is entirely the same across all launches.
# We move it back to the main sames dict for consistency.
if "extracted_args" not in sames_unflattened:
sames_unflattened["extracted_args"] = {}
sames_unflattened["extracted_args"][arg_name] = sames_args[arg_name]

if final_arg_diffs:
diffs_unflattened["extracted_args"] = final_arg_diffs

return sames_unflattened, diffs_unflattened, _to_ranges(launch_index_map)
Loading