Refactor logging configuration and clean up test cases #42
+45
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Removed unused log parsing functions from `test_tritonparse.py` to streamline the test code. - Added calls to `triton.knobs.compilation.listener` and `tritonparse.structured_logging.clear_logging_config()` to ensure proper cleanup and reset of logging configurations after tests. - Improved test reliability by ensuring that logging settings do not persist between test runs. These changes enhance the maintainability of the test suite and ensure that logging configurations are correctly managed during testing.
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
test_tritonparse.pyto streamline the test code.triton.knobs.compilation.listenerandtritonparse.structured_logging.clear_logging_config()to ensure proper cleanup and reset of logging configurations after tests.These changes enhance the maintainability of the test suite and ensure that logging configurations are correctly managed during testing.