[BE] Update .gitignore and add new test output files #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Updated `parse_single_trace_content` to only process compilation events, improving efficiency by skipping non-compilation events. - Enhanced the handling of IR file mappings and bidirectional mappings between different IR types. - Improved the organization of output lines for final writing, ensuring accurate grouping of compilation and launch events by kernel hash. - Added new utility functions for flattening and unflattening dictionaries, and for generating launch diffs, enhancing the overall functionality of the module. These changes aim to streamline the parsing process and improve the clarity and maintainability of the codebase.
Summary: - Introduced `ArgumentViewer` to display argument distributions and differences in a structured format. - Added `DiffViewer` to handle and present differing fields, integrating `ArgumentViewer` for extracted arguments. - Created `StackDiffViewer` to visualize stack traces with collapsible sections for better user experience. - Updated `KernelOverview` to incorporate the new components for enhanced launch analysis and metadata display. - Enhanced `dataLoader` to support launch_diff events, improving kernel data processing. These changes aim to improve the visualization and analysis of kernel launch data, enhancing the overall functionality of the application.
Summary: - Added comments for clarity, including a note for the dropdown arrow icon in both `ArgumentViewer` and `StackDiffViewer`. - Updated the `renderSimpleDiff` function in `DiffViewer` to use a more descriptive parameter name. These changes improve code readability and maintainability across the components.
Summary: - Introduced a new test file `test_complex_kernels.py` to validate the functionality of two distinct Triton kernels: an autotuned matrix multiplication kernel and a fused element-wise operation kernel. - Implemented a comprehensive test plan that includes multiple launches with varied parameters for both kernels, ensuring thorough testing of their performance and correctness. - Enhanced logging capabilities during the tests to facilitate debugging and analysis of kernel launches. These changes aim to improve the testing framework for Triton kernels, ensuring robust validation of their functionality and performance.
Summary: - Updated .gitignore to include patterns for `.ndjson`, `.ndjson.gz`, and `.json` files, while ensuring specific test output directories are excluded from being ignored. - Added a new NDJSON log file for complex kernel tests and a corresponding gzipped version for parsed output. - Created a JSON file to list the log files for the complex kernel tests, enhancing the organization of test outputs. These changes improve the management of test output files and enhance the testing framework for Triton kernels.
meta-cla
bot
added
the
CLA Signed
FindHao
changed the title
davidberard98
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Thanks for adding tests!
Two requests before you land this:
- Can you make the tests use
unittesttest cases - Can you double check whether the changed logging format affects backward compatibility between logs generated by old versions of tritonparse and new versions of the tritonparse CLI/UI? I think you should ensure that old tritonparse logs are still parse-able by new versions of the tritonparse CLI/UI.
| @@ -0,0 +1,256 @@ | |||
| """ | |||
There was a problem hiding this comment.
Is it possible to make this use the unittest framework so that these tests can be more easily run in internal CI?
There was a problem hiding this comment.
let me move this example to the unit tests file rather than putting it in a separate file.
| @@ -928,7 +931,7 @@ def __call__(self, metadata): | |||
| ) | |||
| if launch_metadata_tritonparse is not None: | |||
| trace_data["grid"] = launch_metadata_tritonparse[0] | |||
| trace_data["metadata"] = launch_metadata_tritonparse[1] | |||
| trace_data["compilation_metadata"] = launch_metadata_tritonparse[1] | |||
There was a problem hiding this comment.
just to double check: does this have BC considerations (e.g. will an old tritonparse artifact still be able to be parsed by the new tritonparse UI & CLI tool?
There was a problem hiding this comment.
previously, we didn't do anything for launch event. parsing step just ignore launch event, therefore the website also doesn't take launch event as inputs. so, no other usages for launch event before this feature. We are safe to change this name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
.ndjson,.ndjson.gz, and.jsonfiles, while ensuring specific test output directories are excluded from being ignored.These changes improve the management of test output files and enhance the testing framework for Triton kernels.