Skip to content

[be] Reorganize logging dir #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2025
Merged

[be] Reorganize logging dir #287

merged 4 commits into from
Jul 16, 2025

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Jul 15, 2025

Organize the logging directory. Now log to /tmp/tritonbench_$USER_$LOGGING_GROUP/$BENCHMARK_NAME/$BACKEND_$INPUT_XVAL/$METRIC.<extension>.

Fixes #94

Test plan:

$ python run.py --op softmax --only triton_softmax --num-inputs 1 --metrics kineto_trace,ncu_rep
  x_val                           triton_softmax-kineto_trace                                                triton_softmax-ncu_rep
-------  ----------------------------------------------------  --------------------------------------------------------------------
 2176.0  /tmp/tritonbench_xzhao9/softmax_fwd/triton_softmax_0  /tmp/tritonbench_xzhao9/softmax_fwd/triton_softmax_0/ncu_rep.ncu-rep

$ tree -L 3 /tmp/tritonbench_xzhao9/
/tmp/tritonbench_xzhao9/
└── softmax_fwd
    └── triton_softmax_0
        ├── devvm3059.eag0.facebook.com_1351975.1752690766606139153.pt.trace.json
        ├── devvm3059.eag0.facebook.com_1357864.1752690851550292231.pt.trace.json
        ├── devvm3059.eag0.facebook.com_1358481.1752690861764172111.pt.trace.json
        ├── devvm3059.eag0.facebook.com_1376058.1752691079417859893.pt.trace.json
        └── ncu_rep.ncu-rep

2 directories, 5 files

@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload July 15, 2025 13:52 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload July 15, 2025 13:52 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 requested a review from FindHao July 15, 2025 13:55
@xuzhao9 xuzhao9 changed the title [be] Improve logging dir [be] Reorganize logging dir Jul 15, 2025
Copy link
Member

@FindHao FindHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
nit: can you add a Test Plan? maybe use tree -L 2 to show the output folder structure?

@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload July 16, 2025 18:40 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload July 16, 2025 18:40 — with GitHub Actions Inactive
@xuzhao9
Copy link
Contributor Author

xuzhao9 commented Jul 16, 2025

Addressed comments.

@xuzhao9 xuzhao9 merged commit d28e8e3 into main Jul 16, 2025
7 checks passed
@xuzhao9 xuzhao9 deleted the xz9/fix-metric-dir branch July 16, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming issue about profile reports
3 participants