Skip to content

Add check for second value in sum: Logsumexp #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Add check for second value in sum: Logsumexp #90

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a254c04
Add check for second value in sum: Logsumexp
shivam096 Jan 23, 2025
ca6853c
Add condition for dim consideration
shivam096 Jan 24, 2025
8a28ec0
Update logsumexp condition
shivam096 Jan 31, 2025
beca6d7
Reformat condition
shivam096 Jan 31, 2025
3637b27
Add and update conditions for logsumexp
shivam096 Jan 31, 2025
0db07d1
Update conditions for logsumexp
shivam096 Jan 31, 2025
cf8e693
Add conditions for tuple in dim
shivam096 Feb 1, 2025
e0ee6ff
Resolve flake8 error
shivam096 Feb 1, 2025
0c2edab
Remove redundant code
shivam096 Feb 4, 2025
708eee4
Remove invalid testcase
shivam096 Feb 4, 2025
2762520
Remove invalid testcase
shivam096 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/fixtures/misc/checker/logsumexp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,15 @@
# logsumexp
y = torch.log(torch.sum(torch.exp(x), 1, keepdim=True))
y = torch.log(torch.sum(torch.exp(2.5 + x), 1))
y = torch.log(torch.sum(torch.exp(1),1,1))
y = torch.log(torch.sum(torch.exp(1),1,dim=1))

# not logsumexp
y = torch.log(torch.sum(torch.exp(x), 1, keepdim=True) + 2.5)
y = torch.log(torch.sum(torch.exp(x) + 2.5, 1))
y = torch.log(2 + x)
y = torch.sum(torch.log(torch.exp(x)), 1)
y = torch.exp(torch.sum(torch.log(x), 1, keepdim=True))
y = torch.log(torch.sum(torch.exp(2.5))) # this should not be flagged as the second argument is missing for sum function call
y = torch.sum(torch.log(torch.exp(x)), dim=1)
y = torch.sum(torch.log(torch.exp(x)), dim=None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to the order of calls to log(sum(exp())) as we discussed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought these were false test cases. Will update it

2 changes: 2 additions & 0 deletions tests/fixtures/misc/checker/logsumexp.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
6:5 TOR108 Use numerically stabilized `torch.logsumexp`.
7:5 TOR108 Use numerically stabilized `torch.logsumexp`.
8:5 TOR108 Use numerically stabilized `torch.logsumexp`.
9:5 TOR108 Use numerically stabilized `torch.logsumexp`.
16 changes: 10 additions & 6 deletions torchfix/visitors/misc/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,13 @@ def visit_Call(self, node):
)
== "torch.exp"
):
self.add_violation(
node,
error_code=self.ERRORS[0].error_code,
message=self.ERRORS[0].message(),
replacement=None,
)
if len(node.args[0].value.args) > 1 and (
node.args[0].value.args[1].value is not None
or self.has_specific_arg(node.args[0].value, "dim", -1)
):
self.add_violation(
node,
error_code=self.ERRORS[0].error_code,
message=self.ERRORS[0].message(),
replacement=None,
)
Loading