Skip to content

DOC(README): rule code assignment policy #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

sbrugman
Copy link
Collaborator

@sbrugman sbrugman commented Sep 4, 2024

The documentation should explain the rule code assignment policy, so that its clear which code to pick for newly developed rules.

This was my best guess from the existing rules. Is it correct?

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 4, 2024
@kit1980
Copy link
Contributor

kit1980 commented Sep 10, 2024

The idea was that TOR0, TOR1, and TOR2 are enabled by default.
TOR2 is for domains, now only TorchVision, but in future Torch Data should also go here, for example.

TOR4 is for noisy stuff that should not be enabled by default.
Non-noisy performance stuff should go to TOR1 or even TOR0 if it's very significant.

TOR9 is internal rules specific for pytorch/pytorch repo, other users should not use these.

@kit1980 kit1980 merged commit aef3ea1 into pytorch-labs:main Sep 13, 2024
3 checks passed
@sbrugman sbrugman deleted the patch-2 branch September 14, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants