Skip to content

Move development dependencies to pyproject.toml #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 30, 2024

Conversation

sbrugman
Copy link
Collaborator

Minor PR to kick-off contributing to torchfix. I'm developing new functionality, which I plan to contribute in follow-up PRs.

Changes:

  • Move requirements-dev.txt to optional-dependencies
  • Explicitly set the setuptools build system
  • Omit pip install pre-commit in CONTRIBUTING.md, already included in dev dependencies

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 16, 2024
@kit1980
Copy link
Contributor

kit1980 commented Aug 16, 2024

Thanks!
Something is not right, as pytest is now not found.

@sbrugman
Copy link
Collaborator Author

sbrugman commented Aug 17, 2024

Thanks for the quick reply! Was able to resolve the issues with the CI/CD feedback:

  • Ensured the build dependencies are up-to-date
  • Added the __init__.py file to torch.visitors to make it a proper namespace package

@kit1980 kit1980 merged commit 555bb8d into pytorch-labs:main Aug 30, 2024
2 checks passed
@sbrugman sbrugman deleted the dev-dependencies branch August 31, 2024 17:52
@sbrugman
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants