Skip to content

Add rules for datasets and transforms imports #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

XIIFulminata
Copy link
Contributor

Context

  • There is a linter rule that recommends changing import torchvision.models as models to from torchvision import models
  • The same behavior is expected for torchvision.datasets and torchvision.transforms

Changes

  • Extend the models rule to also address the first instance of the datasets and transforms imports
  • Rename the models import checker and related fixtures to be more generic since more imports are checked now

Testing

  • Updated existing unit test and fixture
  • No lint errors for modified files

@facebook-github-bot
Copy link

Hi @XIIFulminata!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 13, 2024
@kit1980
Copy link
Contributor

kit1980 commented Jun 13, 2024

Thanks, looks good overall.
Could you also update codemod tests:
https://github.com/pytorch-labs/torchfix/blob/main/tests/fixtures/vision/codemod/models_import.py
https://github.com/pytorch-labs/torchfix/blob/main/tests/fixtures/vision/codemod/models_import.py.out

@kit1980
Copy link
Contributor

kit1980 commented Jun 13, 2024

LGTM, thanks!

@kit1980 kit1980 merged commit f3dd694 into pytorch-labs:main Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants