Fixes in the CMake install setup for EXPORT #103
+7
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Hmm. The problem is that after install, the target is namespaced, but before install, it's not. I'll have to look into what we're supposed to do |
- lib64 is not consistently used; usually it's lib, and CMAKE_INSTALL_LIBDIR is the right way to get the name - the link options for regex_lookahead are already exported; don't need to do them again in our manual config.cmake - had to unbreak the macros we use to set the link options so that they work when exported, though
|
added namespace-prefixed aliases for the tokenizers targets for internal use |
|
not sure if the existing test failure is a real problem. looks like labs doesn't have HUD? https://github.com/pytorch-labs/tokenizers/actions/runs/16330717524/job/46132342175?pr=103#step:15:1315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes seem necessary to support pytorch/executorch#8954 .