[18/n] tensor engine: Simplify CallFunctionError #552
Closed
+194
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only case we every 'catch' is DependentError. Everything else is just a textural description. So this collapses those cases into just the two cases. This retains the enum variants as function calls so that we can also reify them again if we need to catch them but having them obscures the places where DependentError needs to be handled differently. Differential Revision: [D78363663](https://our.internmc.facebook.com/intern/diff/D78363663/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78363663/)! [ghstack-poisoned]
meta-cla
bot
added
the
CLA Signed
zdevito
added a commit
that referenced
this pull request
Jul 16, 2025
The only case we every 'catch' is DependentError. Everything else is just a textural description. So this collapses those cases into just the two cases. This retains the enum variants as function calls so that we can also reify them again if we need to catch them but having them obscures the places where DependentError needs to be handled differently. Differential Revision: [D78363663](https://our.internmc.facebook.com/intern/diff/D78363663/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78363663/)! ghstack-source-id: 296602704 Pull Request resolved: #552
|
This pull request was exported from Phabricator. Differential Revision: D78363663 |
|
This pull request has been merged in be4c97d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The only case we every 'catch' is DependentError. Everything else is just a textural description. So this collapses those cases into just the two cases.
This retains the enum variants as function calls so that we can also reify them again if we need to catch them but having them obscures the places where DependentError needs to be handled differently.
Differential Revision: D78363663
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!