Skip to content

Clean up unused code and stale comment #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion hyperactor_mesh/src/actor_mesh.rs
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ where
sender.clone(),
actor_mesh_shape.clone(),
message,
None, // TODO: reducer typehash
)?;

comm_actor_ref.send(
Expand Down
2 changes: 0 additions & 2 deletions hyperactor_mesh/src/comm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,6 @@ impl CommActor {
message.shape().clone(),
message.sender().clone(),
);
// TODO(pzhang) split reply ports so children can reply to this comm
// actor instead of parent.
cx.post(
cx.self_id()
.proc_id()
Expand Down
5 changes: 0 additions & 5 deletions hyperactor_mesh/src/comm/multicast.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ pub struct CastMessageEnvelope {
dest_port: DestinationPort,
/// The serialized message.
data: ErasedUnbound,
/// typehash of the reducer used to accumulate the message in split ports.
pub reducer_typehash: Option<u64>,
/// The shape of the cast.
shape: Shape,
}
Expand All @@ -67,7 +65,6 @@ impl CastMessageEnvelope {
sender: ActorId,
shape: Shape,
message: M,
reducer_typehash: Option<u64>,
) -> Result<Self, anyhow::Error>
where
A: RemoteActor + RemoteHandles<IndexedErasedUnbound<M>>,
Expand All @@ -80,7 +77,6 @@ impl CastMessageEnvelope {
sender,
dest_port: DestinationPort::new::<A, M>(actor_name),
data,
reducer_typehash,
shape,
})
}
Expand All @@ -100,7 +96,6 @@ impl CastMessageEnvelope {
sender,
dest_port,
data: ErasedUnbound::new(data),
reducer_typehash: None,
shape,
}
}
Expand Down
Loading