Python actor mesh supervision support #522
Open
+797
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff exposes the Rust ActorMesh supervision API to Python ActorMesh. It also wires the supervision events to endpoint calls, including *call()/call_one()/choose()/stream()*. So when a supervision error happens, all inflight calls will get notified, new calls will be failed. The current diff fails the whole mesh when any actor fails in the mesh. A followup diff will provide more granular management here, such that we may only fail the calls that actually expect reply from the failed actors. Reviewed By: colin2328 Differential Revision: D77434080
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77434080 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff exposes the Rust ActorMesh supervision API to Python ActorMesh. It also wires the supervision events to endpoint calls, including call()/call_one()/choose()/stream(). So when a supervision error happens, all inflight calls will get notified, new calls will be failed.
The current diff fails the whole mesh when any actor fails in the mesh. A followup diff will provide more granular management here, such that we may only fail the calls that actually expect reply from the failed actors.
Reviewed By: colin2328
Differential Revision: D77434080