: selection: handle dim mismatch in reify_view #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78035345 |
shayne-fletcher
force-pushed
the
export-D78035345
branch
from
682601e to
23b3a1d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78035345 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 10, 2025
Summary: improve `reify_view` to support dimension mismatches by falling back to `Selection::of_ranks`. this enables `reify_views` to be used in `mesh_controller`, simplifying cast selection logic. also improves ergonomics by allowing `reify_views` to accept slices directly (e.g., `&[Slice]` or `Vec<Slice>`). Differential Revision: D78035345
shayne-fletcher
force-pushed
the
export-D78035345
branch
from
23b3a1d to
f120bab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78035345 |
Summary: - remove the `DestinationPort` arg from `CastMessageEnvelope::new` since it can be calculated from the other arguments - remove now unnecessary arguments from the utility `actor_mesh::actor_mesh_cast` (proc mesh shape and actor name) - generally make the handling of generics consistent in these interfaces Differential Revision: D78030552
Summary: improve `reify_view` to support dimension mismatches by falling back to `Selection::of_ranks`. this enables `reify_views` to be used in `mesh_controller`, simplifying cast selection logic. also improves ergonomics by allowing `reify_views` to accept slices directly (e.g., `&[Slice]` or `Vec<Slice>`). Differential Revision: D78035345
shayne-fletcher
force-pushed
the
export-D78035345
branch
from
f120bab to
e34a0f2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78035345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D78035345