Skip to content

: actor_mesh: remove redundant params #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

shayne-fletcher
Copy link
Contributor

Summary:

  • remove the DestinationPort arg from CastMessageEnvelope::new since it can be calculated from the other arguments
  • remove now unnecessary arguments from the utility actor_mesh::actor_mesh_cast (proc mesh shape and actor name)
  • generally make the handling of generics consistent in these interfaces consistent

Differential Revision: D78030552

Summary:

- in D77963903, routing was updated to use the `(ActorMeshId, ActorId)` pair as the stream key for sequence number tracking. this change allows different sub-slices of a mesh to safely share a common stream identity as long as they belong to the same logical `ActorMeshId`, avoiding issues like message reordering or duplication due to slice mismatch. as a result, this diff removes the now-unnecessary logic that intersected the user-provided selection with a reified view of the actor mesh's slice. correctness depends on all casts to a given `ActorMeshId`  being evaluated consistently against that mesh's slice.

- previously, `cast_slices` didn’t perform a true cast; it sent messages point-to-point to each rank in the input slices. now, we replace it with a `Selection` constructed via `Selection::of_ranks` and `dsl::union`, and invoke `cast`. the unused `cast_slices` is removed.

Reviewed By: mariusae

Differential Revision: D77953855
Summary:
- remove the `DestinationPort` arg from `CastMessageEnvelope::new` since it can be calculated from the other arguments
- remove now unnecessary arguments from the utility `actor_mesh::actor_mesh_cast` (proc mesh shape and actor name)
- generally make the handling of generics consistent in these interfaces consistent

Differential Revision: D78030552
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 9, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78030552

shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request Jul 9, 2025
Summary:

- remove the `DestinationPort` arg from `CastMessageEnvelope::new` since it can be calculated from the other arguments
- remove now unnecessary arguments from the utility `actor_mesh::actor_mesh_cast` (proc mesh shape and actor name)
- generally make the handling of generics consistent in these interfaces consistent

Differential Revision: D78030552
shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request Jul 9, 2025
Summary:

- remove the `DestinationPort` arg from `CastMessageEnvelope::new` since it can be calculated from the other arguments
- remove now unnecessary arguments from the utility `actor_mesh::actor_mesh_cast` (proc mesh shape and actor name)
- generally make the handling of generics consistent in these interfaces

Differential Revision: D78030552
shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request Jul 10, 2025
Summary:

- remove the `DestinationPort` arg from `CastMessageEnvelope::new` since it can be calculated from the other arguments
- remove now unnecessary arguments from the utility `actor_mesh::actor_mesh_cast` (proc mesh shape and actor name)
- generally make the handling of generics consistent in these interfaces

Differential Revision: D78030552
shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request Jul 10, 2025
Summary:

- remove the `DestinationPort` arg from `CastMessageEnvelope::new` since it can be calculated from the other arguments
- remove now unnecessary arguments from the utility `actor_mesh::actor_mesh_cast` (proc mesh shape and actor name)
- generally make the handling of generics consistent in these interfaces

Differential Revision: D78030552
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7fb56d0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants