-
Notifications
You must be signed in to change notification settings - Fork 47
: actor_mesh: remove redundant params #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
shayne-fletcher
wants to merge
2
commits into
pytorch-labs:main
from
shayne-fletcher:export-D78030552
Closed
: actor_mesh: remove redundant params #481
shayne-fletcher
wants to merge
2
commits into
pytorch-labs:main
from
shayne-fletcher:export-D78030552
+75
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - in D77963903, routing was updated to use the `(ActorMeshId, ActorId)` pair as the stream key for sequence number tracking. this change allows different sub-slices of a mesh to safely share a common stream identity as long as they belong to the same logical `ActorMeshId`, avoiding issues like message reordering or duplication due to slice mismatch. as a result, this diff removes the now-unnecessary logic that intersected the user-provided selection with a reified view of the actor mesh's slice. correctness depends on all casts to a given `ActorMeshId` being evaluated consistently against that mesh's slice. - previously, `cast_slices` didn’t perform a true cast; it sent messages point-to-point to each rank in the input slices. now, we replace it with a `Selection` constructed via `Selection::of_ranks` and `dsl::union`, and invoke `cast`. the unused `cast_slices` is removed. Reviewed By: mariusae Differential Revision: D77953855
Summary: - remove the `DestinationPort` arg from `CastMessageEnvelope::new` since it can be calculated from the other arguments - remove now unnecessary arguments from the utility `actor_mesh::actor_mesh_cast` (proc mesh shape and actor name) - generally make the handling of generics consistent in these interfaces consistent Differential Revision: D78030552
This pull request was exported from Phabricator. Differential Revision: D78030552 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 9, 2025
Summary: - remove the `DestinationPort` arg from `CastMessageEnvelope::new` since it can be calculated from the other arguments - remove now unnecessary arguments from the utility `actor_mesh::actor_mesh_cast` (proc mesh shape and actor name) - generally make the handling of generics consistent in these interfaces consistent Differential Revision: D78030552
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 9, 2025
Summary: - remove the `DestinationPort` arg from `CastMessageEnvelope::new` since it can be calculated from the other arguments - remove now unnecessary arguments from the utility `actor_mesh::actor_mesh_cast` (proc mesh shape and actor name) - generally make the handling of generics consistent in these interfaces Differential Revision: D78030552
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 10, 2025
Summary: - remove the `DestinationPort` arg from `CastMessageEnvelope::new` since it can be calculated from the other arguments - remove now unnecessary arguments from the utility `actor_mesh::actor_mesh_cast` (proc mesh shape and actor name) - generally make the handling of generics consistent in these interfaces Differential Revision: D78030552
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 10, 2025
Summary: - remove the `DestinationPort` arg from `CastMessageEnvelope::new` since it can be calculated from the other arguments - remove now unnecessary arguments from the utility `actor_mesh::actor_mesh_cast` (proc mesh shape and actor name) - generally make the handling of generics consistent in these interfaces Differential Revision: D78030552
This pull request has been merged in 7fb56d0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
DestinationPort
arg fromCastMessageEnvelope::new
since it can be calculated from the other argumentsactor_mesh::actor_mesh_cast
(proc mesh shape and actor name)Differential Revision: D78030552