local_proc_mesh with sim channels #475
Open
+490
−1,011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77941640 |
|
This pull request was exported from Phabricator. Differential Revision: D77941640 |
thomasywang
force-pushed
the
export-D77941640
branch
from
a6e1312 to
46e855f
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Jul 9, 2025
Summary: Pull Request resolved: pytorch-labs#475 We want to instantiate local_proc_meshes that use ChannelTransport::SIm instead of ChannelTranport::Local so that the simulator can intercept and control the delivery of messages To preserve to `allocate()` interface so that we can reuse existing test generation macros we will create a wrapper class for this around `LocalAlloc` Differential Revision: D77941640
|
This pull request was exported from Phabricator. Differential Revision: D77941640 |
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Jul 9, 2025
Summary: Pull Request resolved: pytorch-labs#475 We want to instantiate local_proc_meshes that use ChannelTransport::SIm instead of ChannelTranport::Local so that the simulator can intercept and control the delivery of messages To preserve to `allocate()` interface so that we can reuse existing test generation macros we will create a wrapper class for this around `LocalAlloc` Differential Revision: D77941640
thomasywang
force-pushed
the
export-D77941640
branch
from
46e855f to
a4e11cb
Compare
Summary: Operational messages were used in order to signal to the simulator that it should perform certain actions like growing or shrinking the mesh. This was needed since the python and rust were running in separate processes, and messages were needed to communicate between the two, but now everything is on the same process so we can do this in memory. Differential Revision: D77941643
Summary: The proxy was previously used since the simulator and the python were run in separate processes. Since both are now run in the same process we no longer need a proxy Differential Revision: D77941641
Summary: Pull Request resolved: pytorch-labs#475 We want to instantiate local_proc_meshes that use ChannelTransport::SIm instead of ChannelTranport::Local so that the simulator can intercept and control the delivery of messages To preserve to `allocate()` interface so that we can reuse existing test generation macros we will create a wrapper class for this around `LocalAlloc` Differential Revision: D77941640
|
This pull request was exported from Phabricator. Differential Revision: D77941640 |
thomasywang
force-pushed
the
export-D77941640
branch
from
a4e11cb to
1f5fe31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We want to instantiate local_proc_meshes that use ChannelTransport::SIm instead of ChannelTranport::Local so that the simulator can intercept and control the delivery of messages
Rollback Plan:
Differential Revision: D77941640