Remove proxy #474
Open
Remove proxy #474
+222
−1,007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77941641 |
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Jul 9, 2025
Summary: The proxy was a construct previously used to for other processes to communicate with the simulator. Since all simulation is now done in a single process we no longer need this and can delete a nice chunk of code Differential Revision: D77941641
thomasywang
force-pushed
the
export-D77941641
branch
from
9f595ff to
83bfc84
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77941641 |
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Jul 9, 2025
Summary: The proxy was a construct previously used to for other processes to communicate with the simulator. Since all simulation is now done in a single process we no longer need this and can delete a nice chunk of code Differential Revision: D77941641
thomasywang
force-pushed
the
export-D77941641
branch
from
83bfc84 to
6e19d3b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77941641 |
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Jul 9, 2025
Summary: Pull Request resolved: pytorch-labs#474 The proxy was a construct previously used to for other processes to communicate with the simulator. Since all simulation is now done in a single process we no longer need this and can delete a nice chunk of code Differential Revision: D77941641
thomasywang
force-pushed
the
export-D77941641
branch
from
6e19d3b to
a1dfaf8
Compare
Summary: Operational messages were used in order to signal to the simulator that it should perform certain actions like growing or shrinking the mesh. This was needed since the python and rust were running in separate processes, and messages were needed to communicate between the two, but now everything is on the same process so we can do this in memory. Differential Revision: D77941643
thomasywang
force-pushed
the
export-D77941641
branch
from
a1dfaf8 to
88f5a49
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Jul 10, 2025
Summary: The proxy was a construct previously used to for other processes to communicate with the simulator. Since all simulation is now done in a single process we no longer need this and can delete a nice chunk of code Differential Revision: D77941641
Summary: Pull Request resolved: pytorch-labs#474 The proxy was a construct previously used to for other processes to communicate with the simulator. Since all simulation is now done in a single process we no longer need this and can delete a nice chunk of code Differential Revision: D77941641
|
This pull request was exported from Phabricator. Differential Revision: D77941641 |
thomasywang
force-pushed
the
export-D77941641
branch
from
88f5a49 to
8518a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The proxy was previously used since the simulator and the python were run in separate processes. Since both are now run in the same process we no longer need a proxy
Differential Revision: D77941641