Invert rsync architecture #467
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77952087 |
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 8, 2025
Summary: This inverts the rsync setup, so that the rsync daemon runs on the "client", and the rsync clients run on the actors. This helps in a couple ways: - We don't leave a rsync daemon running on the actors. - We avoid spawning lots of sub-processes for each rsync client on the "client" - The rsync client supports reporting file changes, which subsequent changes can use to facilitate things like targeted module reloading (based on the actual things that were changed). Differential Revision: D77952087
andrewjcg
force-pushed
the
export-D77952087
branch
from
f44d99f to
657fc59
Compare
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 8, 2025
Summary: This inverts the rsync setup, so that the rsync daemon runs on the "client", and the rsync clients run on the actors. This helps in a couple ways: - We don't leave a rsync daemon running on the actors. - We avoid spawning lots of sub-processes for each rsync client on the "client" - The rsync client supports reporting file changes, which subsequent changes can use to facilitate things like targeted module reloading (based on the actual things that were changed). Differential Revision: D77952087
andrewjcg
force-pushed
the
export-D77952087
branch
from
657fc59 to
5e92b4c
Compare
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 8, 2025
Summary: This inverts the rsync setup, so that the rsync daemon runs on the "client", and the rsync clients run on the actors. This helps in a couple ways: - We don't leave a rsync daemon running on the actors. - We avoid spawning lots of sub-processes for each rsync client on the "client" - The rsync client supports reporting file changes, which subsequent changes can use to facilitate things like targeted module reloading (based on the actual things that were changed). Differential Revision: D77952087
andrewjcg
force-pushed
the
export-D77952087
branch
from
5e92b4c to
358f0a5
Compare
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 8, 2025
Summary: This inverts the rsync setup, so that the rsync daemon runs on the "client", and the rsync clients run on the actors. This helps in a couple ways: - We don't leave a rsync daemon running on the actors. - We avoid spawning lots of sub-processes for each rsync client on the "client" - The rsync client supports reporting file changes, which subsequent changes can use to facilitate things like targeted module reloading (based on the actual things that were changed). Differential Revision: D77952087
andrewjcg
force-pushed
the
export-D77952087
branch
from
358f0a5 to
151dc69
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77952087 |
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 8, 2025
Summary: Pull Request resolved: pytorch-labs#467 This inverts the rsync setup, so that the rsync daemon runs on the "client", and the rsync clients run on the actors. This helps in a couple ways: - We don't leave a rsync daemon running on the actors. - We avoid spawning lots of sub-processes for each rsync client on the "client" - The rsync client supports reporting file changes, which subsequent changes can use to facilitate things like targeted module reloading (based on the actual things that were changed). Differential Revision: D77952087
andrewjcg
force-pushed
the
export-D77952087
branch
from
151dc69 to
e9dd1c4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77952087 |
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 8, 2025
Summary: Pull Request resolved: pytorch-labs#467 This inverts the rsync setup, so that the rsync daemon runs on the "client", and the rsync clients run on the actors. This helps in a couple ways: - We don't leave a rsync daemon running on the actors. - We avoid spawning lots of sub-processes for each rsync client on the "client" - The rsync client supports reporting file changes, which subsequent changes can use to facilitate things like targeted module reloading (based on the actual things that were changed). Differential Revision: D77952087
andrewjcg
force-pushed
the
export-D77952087
branch
from
e9dd1c4 to
f5d3e82
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77952087 |
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 8, 2025
Summary: Pull Request resolved: pytorch-labs#467 This inverts the rsync setup, so that the rsync daemon runs on the "client", and the rsync clients run on the actors. This helps in a couple ways: - We don't leave a rsync daemon running on the actors. - We avoid spawning lots of sub-processes for each rsync client on the "client" - The rsync client supports reporting file changes, which subsequent changes can use to facilitate things like targeted module reloading (based on the actual things that were changed). Differential Revision: D77952087
andrewjcg
force-pushed
the
export-D77952087
branch
from
f5d3e82 to
a243ee3
Compare
Summary: Pull Request resolved: pytorch-labs#467 This inverts the rsync setup, so that the rsync daemon runs on the "client", and the rsync clients run on the actors. This helps in a couple ways: - We don't leave a rsync daemon running on the actors. - We avoid spawning lots of sub-processes for each rsync client on the "client" - The rsync client supports reporting file changes, which subsequent changes can use to facilitate things like targeted module reloading (based on the actual things that were changed). Differential Revision: D77952087
|
This pull request was exported from Phabricator. Differential Revision: D77952087 |
andrewjcg
force-pushed
the
export-D77952087
branch
from
a243ee3 to
e097f59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This inverts the rsync setup, so that the rsync daemon runs on the "client", and the
rsync clients run on the actors. This helps in a couple ways:
can use to facilitate things like targeted module reloading (based on the actual
things that were changed).
Differential Revision: D77952087