tensor engine, fix bugs to make test_remote_functions pass (#455) #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77880706 |
facebook-github-bot
force-pushed
the
export-D77880706
branch
from
0dc1eb1 to
b214594
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77880706 |
Summary: Pull Request resolved: #469 Fixes: * formatting of error messages * transposition of all_gathers, via a workaround. the real fix relies on fixing nccl-comm actor to respect the order of dimensions in process groups. * cloning of WireValue, which drops the is_wrapped_number property incorrectly. ghstack-source-id: 295007765 exported-using-ghexport Reviewed By: colin2328, suo Differential Revision: D77880706
|
This pull request was exported from Phabricator. Differential Revision: D77880706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes:
ghstack-source-id: 294881245
exported-using-ghexport
Differential Revision: D77880706