: actor_mesh: use commactor in cast_slices #461
+14
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77935610 |
shayne-fletcher
force-pushed
the
export-D77935610
branch
from
58978af to
1a3986d
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 8, 2025
Summary: refactor `cast_slices`. the old approach iterated over the input slices and for each rank in each slice, sent a message. now, call `reify_views` on the input slices to produce a single `Selection` (union of ranges). then, cast the message to the selected ranks via the comm actor. Differential Revision: D77935610
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 8, 2025
Summary: refactor `cast_slices`. the old approach iterated over the input slices and for each rank in each slice, sent a message. now, call `reify_views` on the input slices to produce a single `Selection` (union of ranges). then, cast the message to the selected ranks via the comm actor. Differential Revision: D77935610
shayne-fletcher
force-pushed
the
export-D77935610
branch
from
1a3986d to
8c11394
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77935610 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 8, 2025
Summary: Pull Request resolved: pytorch-labs#461 refactor `cast_slices`. the old approach iterated over the input slices and for each rank in each slice, sent a message. now, call `reify_views` on the input slices to produce a single `Selection` (union of ranges). then, cast the message to the selected ranks via the comm actor. Differential Revision: D77935610
shayne-fletcher
force-pushed
the
export-D77935610
branch
from
8c11394 to
d81d927
Compare
Summary: Pull Request resolved: pytorch-labs#461 refactor `cast_slices`. the old approach iterated over the input slices and for each rank in each slice, sent a message. now, call `reify_views` on the input slices to produce a single `Selection` (union of ranges). then, cast the message to the selected ranks via the comm actor. Differential Revision: D77935610
|
This pull request was exported from Phabricator. Differential Revision: D77935610 |
shayne-fletcher
force-pushed
the
export-D77935610
branch
from
d81d927 to
7a8fb6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: refactor
cast_slices. the old approach iterated over the input slices and for each rank in each slice, sent a message. now, callreify_viewson the input slices to produce a singleSelection(union of ranges). then, cast the message to the selected ranks via the comm actor.Differential Revision: D77935610