(10/n - non-xlformers conda-on-mast mvp)(monarch-fb/BUCK) Include torchx-fb as part of monarch.whl #439
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77411375 |
kiukchung
added a commit
that referenced
this pull request
Jul 7, 2025
…chx-fb as part of monarch.whl (#439) Summary: To bundle torchx-fb (with internal plugins such as being able to launch on MAST) build the wheel with: ``` buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl ``` To install: ``` pip install --force-reinstall --no-deps $(BUILD_CMD_ABOVE) ``` WARNING: monarch + torchx doesn't work yet! this is why it is behind the `--config monarch_whl.include=torchx`! I'm landing this so that others can repro the error and I can get help fixing it. ## Repro Instructions: ``` $ $HOME/fbsource/genai/xlformers/dev/xl_conda.sh xlformers_finetune_conda:stable $ cd ~/fbsource/fbcode $ pip install --force-reinstall --no-deps $(buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl) $ cd ~/fbsource/fbcode/scripts/kiuk/examples/monarch_conda $ python main.py ``` should fail with ``` import monarch._rust_bindings ImportError: /home/kiuk/.fbpkg_conda_envs/xlformers_finetune_conda-9648802/lib/python3.10/site-packages/monarch/../monarch/lib/libomnibus.so: undefined symbol: __kmpc_fork_call ``` Reviewed By: highker Differential Revision: D77411375
kiukchung
force-pushed
the
export-D77411375
branch
from
3149116 to
71eca0e
Compare
kiukchung
added a commit
that referenced
this pull request
Jul 7, 2025
…chx-fb as part of monarch.whl (#439) Summary: To bundle torchx-fb (with internal plugins such as being able to launch on MAST) build the wheel with: ``` buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl ``` To install: ``` pip install --force-reinstall --no-deps $(BUILD_CMD_ABOVE) ``` WARNING: monarch + torchx doesn't work yet! this is why it is behind the `--config monarch_whl.include=torchx`! I'm landing this so that others can repro the error and I can get help fixing it. ## Repro Instructions: ``` $ $HOME/fbsource/genai/xlformers/dev/xl_conda.sh xlformers_finetune_conda:stable $ cd ~/fbsource/fbcode $ pip install --force-reinstall --no-deps $(buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl) $ cd ~/fbsource/fbcode/scripts/kiuk/examples/monarch_conda $ python main.py ``` should fail with ``` import monarch._rust_bindings ImportError: /home/kiuk/.fbpkg_conda_envs/xlformers_finetune_conda-9648802/lib/python3.10/site-packages/monarch/../monarch/lib/libomnibus.so: undefined symbol: __kmpc_fork_call ``` Reviewed By: highker Differential Revision: D77411375
kiukchung
force-pushed
the
export-D77411375
branch
from
71eca0e to
3f65731
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77411375 |
kiukchung
added a commit
that referenced
this pull request
Jul 7, 2025
…chx-fb as part of monarch.whl (#439) Summary: Pull Request resolved: #439 To bundle torchx-fb (with internal plugins such as being able to launch on MAST) build the wheel with: ``` buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl ``` To install: ``` pip install --force-reinstall --no-deps $(BUILD_CMD_ABOVE) ``` WARNING: monarch + torchx doesn't work yet! this is why it is behind the `--config monarch_whl.include=torchx`! I'm landing this so that others can repro the error and I can get help fixing it. ## Repro Instructions: ``` $ $HOME/fbsource/genai/xlformers/dev/xl_conda.sh xlformers_finetune_conda:stable $ cd ~/fbsource/fbcode $ pip install --force-reinstall --no-deps $(buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl) $ cd ~/fbsource/fbcode/scripts/kiuk/examples/monarch_conda $ python main.py ``` should fail with ``` import monarch._rust_bindings ImportError: /home/kiuk/.fbpkg_conda_envs/xlformers_finetune_conda-9648802/lib/python3.10/site-packages/monarch/../monarch/lib/libomnibus.so: undefined symbol: __kmpc_fork_call ``` Reviewed By: highker Differential Revision: D77411375
kiukchung
force-pushed
the
export-D77411375
branch
from
3f65731 to
7ee299a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77411375 |
kiukchung
added a commit
that referenced
this pull request
Jul 7, 2025
…chx-fb as part of monarch.whl (#439) Summary: Pull Request resolved: #439 To bundle torchx-fb (with internal plugins such as being able to launch on MAST) build the wheel with: ``` buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl ``` To install: ``` pip install --force-reinstall --no-deps $(BUILD_CMD_ABOVE) ``` WARNING: monarch + torchx doesn't work yet! this is why it is behind the `--config monarch_whl.include=torchx`! I'm landing this so that others can repro the error and I can get help fixing it. ## Repro Instructions: ``` $ $HOME/fbsource/genai/xlformers/dev/xl_conda.sh xlformers_finetune_conda:stable $ cd ~/fbsource/fbcode $ pip install --force-reinstall --no-deps $(buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl) $ cd ~/fbsource/fbcode/scripts/kiuk/examples/monarch_conda $ python main.py ``` should fail with ``` import monarch._rust_bindings ImportError: /home/kiuk/.fbpkg_conda_envs/xlformers_finetune_conda-9648802/lib/python3.10/site-packages/monarch/../monarch/lib/libomnibus.so: undefined symbol: __kmpc_fork_call ``` Reviewed By: highker Differential Revision: D77411375
kiukchung
force-pushed
the
export-D77411375
branch
from
7ee299a to
28facf7
Compare
kiukchung
added a commit
that referenced
this pull request
Jul 8, 2025
…chx-fb as part of monarch.whl (#439) Summary: To bundle torchx-fb (with internal plugins such as being able to launch on MAST) build the wheel with: ``` buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl ``` To install: ``` pip install --force-reinstall --no-deps $(BUILD_CMD_ABOVE) ``` WARNING: monarch + torchx doesn't work yet! this is why it is behind the `--config monarch_whl.include=torchx`! I'm landing this so that others can repro the error and I can get help fixing it. ## Repro Instructions: ``` $ $HOME/fbsource/genai/xlformers/dev/xl_conda.sh xlformers_finetune_conda:stable $ cd ~/fbsource/fbcode $ pip install --force-reinstall --no-deps $(buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl) $ cd ~/fbsource/fbcode/scripts/kiuk/examples/monarch_conda $ python main.py ``` should fail with ``` import monarch._rust_bindings ImportError: /home/kiuk/.fbpkg_conda_envs/xlformers_finetune_conda-9648802/lib/python3.10/site-packages/monarch/../monarch/lib/libomnibus.so: undefined symbol: __kmpc_fork_call ``` Reviewed By: highker Differential Revision: D77411375
kiukchung
force-pushed
the
export-D77411375
branch
from
28facf7 to
c12bfc0
Compare
kiukchung
added a commit
that referenced
this pull request
Jul 8, 2025
…chx-fb as part of monarch.whl (#439) Summary: To bundle torchx-fb (with internal plugins such as being able to launch on MAST) build the wheel with: ``` buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl ``` To install: ``` pip install --force-reinstall --no-deps $(BUILD_CMD_ABOVE) ``` WARNING: monarch + torchx doesn't work yet! this is why it is behind the `--config monarch_whl.include=torchx`! I'm landing this so that others can repro the error and I can get help fixing it. ## Repro Instructions: ``` $ $HOME/fbsource/genai/xlformers/dev/xl_conda.sh xlformers_finetune_conda:stable $ cd ~/fbsource/fbcode $ pip install --force-reinstall --no-deps $(buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl) $ cd ~/fbsource/fbcode/scripts/kiuk/examples/monarch_conda $ python main.py ``` should fail with ``` import monarch._rust_bindings ImportError: /home/kiuk/.fbpkg_conda_envs/xlformers_finetune_conda-9648802/lib/python3.10/site-packages/monarch/../monarch/lib/libomnibus.so: undefined symbol: __kmpc_fork_call ``` Reviewed By: highker Differential Revision: D77411375
kiukchung
force-pushed
the
export-D77411375
branch
from
c12bfc0 to
3c4bc00
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77411375 |
kiukchung
added a commit
that referenced
this pull request
Jul 8, 2025
…chx-fb as part of monarch.whl (#439) Summary: Pull Request resolved: #439 To bundle torchx-fb (with internal plugins such as being able to launch on MAST) build the wheel with: ``` buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl ``` To install: ``` pip install --force-reinstall --no-deps $(BUILD_CMD_ABOVE) ``` WARNING: monarch + torchx doesn't work yet! this is why it is behind the `--config monarch_whl.include=torchx`! I'm landing this so that others can repro the error and I can get help fixing it. ## Repro Instructions: ``` $ $HOME/fbsource/genai/xlformers/dev/xl_conda.sh xlformers_finetune_conda:stable $ cd ~/fbsource/fbcode $ pip install --force-reinstall --no-deps $(buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl) $ cd ~/fbsource/fbcode/scripts/kiuk/examples/monarch_conda $ python main.py ``` should fail with ``` import monarch._rust_bindings ImportError: /home/kiuk/.fbpkg_conda_envs/xlformers_finetune_conda-9648802/lib/python3.10/site-packages/monarch/../monarch/lib/libomnibus.so: undefined symbol: __kmpc_fork_call ``` Reviewed By: highker Differential Revision: D77411375
kiukchung
force-pushed
the
export-D77411375
branch
from
3c4bc00 to
a29cd5e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77411375 |
kiukchung
added a commit
that referenced
this pull request
Jul 8, 2025
…chx-fb as part of monarch.whl (#439) Summary: Pull Request resolved: #439 To bundle torchx-fb (with internal plugins such as being able to launch on MAST) build the wheel with: ``` buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl ``` To install: ``` pip install --force-reinstall --no-deps $(BUILD_CMD_ABOVE) ``` WARNING: monarch + torchx doesn't work yet! this is why it is behind the `--config monarch_whl.include=torchx`! I'm landing this so that others can repro the error and I can get help fixing it. ## Repro Instructions: ``` $ $HOME/fbsource/genai/xlformers/dev/xl_conda.sh xlformers_finetune_conda:stable $ cd ~/fbsource/fbcode $ pip install --force-reinstall --no-deps $(buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl) $ cd ~/fbsource/fbcode/scripts/kiuk/examples/monarch_conda $ python main.py ``` should fail with ``` import monarch._rust_bindings ImportError: /home/kiuk/.fbpkg_conda_envs/xlformers_finetune_conda-9648802/lib/python3.10/site-packages/monarch/../monarch/lib/libomnibus.so: undefined symbol: __kmpc_fork_call ``` Reviewed By: highker Differential Revision: D77411375
kiukchung
force-pushed
the
export-D77411375
branch
from
a29cd5e to
82b79e8
Compare
kiukchung
added a commit
that referenced
this pull request
Jul 9, 2025
…chx-fb as part of monarch.whl (#439) Summary: To bundle torchx-fb (with internal plugins such as being able to launch on MAST) build the wheel with: ``` buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl ``` To install: ``` pip install --force-reinstall --no-deps $(BUILD_CMD_ABOVE) ``` WARNING: monarch + torchx doesn't work yet! this is why it is behind the `--config monarch_whl.include=torchx`! I'm landing this so that others can repro the error and I can get help fixing it. ## Repro Instructions: ``` $ $HOME/fbsource/genai/xlformers/dev/xl_conda.sh xlformers_finetune_conda:stable $ cd ~/fbsource/fbcode $ pip install --force-reinstall --no-deps $(buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl) $ cd ~/fbsource/fbcode/scripts/kiuk/examples/monarch_conda $ python main.py ``` should fail with ``` import monarch._rust_bindings ImportError: /home/kiuk/.fbpkg_conda_envs/xlformers_finetune_conda-9648802/lib/python3.10/site-packages/monarch/../monarch/lib/libomnibus.so: undefined symbol: __kmpc_fork_call ``` Reviewed By: highker Differential Revision: D77411375
kiukchung
force-pushed
the
export-D77411375
branch
from
82b79e8 to
e543500
Compare
kiukchung
added a commit
that referenced
this pull request
Jul 9, 2025
…chx-fb as part of monarch.whl (#439) Summary: To bundle torchx-fb (with internal plugins such as being able to launch on MAST) build the wheel with: ``` buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl ``` To install: ``` pip install --force-reinstall --no-deps $(BUILD_CMD_ABOVE) ``` WARNING: monarch + torchx doesn't work yet! this is why it is behind the `--config monarch_whl.include=torchx`! I'm landing this so that others can repro the error and I can get help fixing it. ## Repro Instructions: ``` $ $HOME/fbsource/genai/xlformers/dev/xl_conda.sh xlformers_finetune_conda:stable $ cd ~/fbsource/fbcode $ pip install --force-reinstall --no-deps $(buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl) $ cd ~/fbsource/fbcode/scripts/kiuk/examples/monarch_conda $ python main.py ``` should fail with ``` import monarch._rust_bindings ImportError: /home/kiuk/.fbpkg_conda_envs/xlformers_finetune_conda-9648802/lib/python3.10/site-packages/monarch/../monarch/lib/libomnibus.so: undefined symbol: __kmpc_fork_call ``` Reviewed By: highker Differential Revision: D77411375
kiukchung
force-pushed
the
export-D77411375
branch
from
e543500 to
af64d9a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77411375 |
kiukchung
added a commit
that referenced
this pull request
Jul 9, 2025
…chx-fb as part of monarch.whl (#439) Summary: Pull Request resolved: #439 To bundle torchx-fb (with internal plugins such as being able to launch on MAST) build the wheel with: ``` buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl ``` To install: ``` pip install --force-reinstall --no-deps $(BUILD_CMD_ABOVE) ``` WARNING: monarch + torchx doesn't work yet! this is why it is behind the `--config monarch_whl.include=torchx`! I'm landing this so that others can repro the error and I can get help fixing it. ## Repro Instructions: ``` $ $HOME/fbsource/genai/xlformers/dev/xl_conda.sh xlformers_finetune_conda:stable $ cd ~/fbsource/fbcode $ pip install --force-reinstall --no-deps $(buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl) $ cd ~/fbsource/fbcode/scripts/kiuk/examples/monarch_conda $ python main.py ``` should fail with ``` import monarch._rust_bindings ImportError: /home/kiuk/.fbpkg_conda_envs/xlformers_finetune_conda-9648802/lib/python3.10/site-packages/monarch/../monarch/lib/libomnibus.so: undefined symbol: __kmpc_fork_call ``` Reviewed By: highker Differential Revision: D77411375
kiukchung
force-pushed
the
export-D77411375
branch
from
af64d9a to
3ee4f16
Compare
…chx-fb as part of monarch.whl (#439) Summary: Pull Request resolved: #439 Includes torchx_fb in `//monarch/python/monarch:monarch.whl` so that `monarch.tools.*` module (uses torchx programmatically) works. NOTE: Currently fails with `AttributeError: type object '_asyncio.Task' has no attribute '_step'` (full stacktrace: P1864708102) ## Repro Instructions: 1. Activate `xlformers_finetune_conda:stable` ``` $HOME/fbsource/genai/xlformers/dev/xl_conda.sh xlformers_finetune_conda:stable ``` 2. Build and install `monarch.whl` ``` $ cd ~/fbsource/fbcode $ pip install --force-reinstall --no-deps $(buck build @//mode/opt --show-full-simple-output --config monarch_whl.include=torchx //monarch/python/monarch:monarch.whl) ``` 3. Run the script (should fail with P1864708102) ``` $ cd ~/fbsource/fbcode/scripts/kiuk/examples/monarch_conda $ python main.py ``` Reviewed By: highker Differential Revision: D77411375
|
This pull request was exported from Phabricator. Differential Revision: D77411375 |
kiukchung
force-pushed
the
export-D77411375
branch
from
3ee4f16 to
8959456
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To bundle torchx-fb (with internal plugins such as being able to launch on MAST) build the wheel with:
To install:
WARNING: monarch + torchx doesn't work yet! this is why it is behind the
--config monarch_whl.include=torchx! I'm landing this so that others can repro the error and I can get help fixing it.Repro Instructions:
should fail with
Reviewed By: highker
Differential Revision: D77411375