Amy #29
Merged
Amy #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copied methods - just minor tweaks for simplicity and compatibility, and set algorithm to aim for 5% (rather than 10%)
…entary to each other
…o satisfy Still fails some tests (confidence_interval_method is giving different results to other function + algorithm), but some other tests I have add pass thanks to adjustment
Results were wrong as it was provided as series to data in OnlineStatistics. At validation to OnlineStatistics to prevent this, and test to check that OnlineStatistics fails with this input type.
Remove _observers and notify(), and instead just save observer as class attribute and run update directly within update()
Also, renamed the output plots to more meaningful names
…ions in parallel, and will only check precision after all have been run (and not for each)
…nly check precision after all initial replications have been run (and not for each)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.