Re-add class properties #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed 2 years ago with intention of being reimplemented better, but this did not happen.
|
I’ll give this a look tomorrow. I don’t have a problem merging it in, but I’ll need to follow it up with support for it in the JSON parser and tests for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed 2 years ago with intention of being reimplemented better, but this did not happen.
A project I'm on the team of really needs this functionality, and the old code, even if it could be better, still works. It doesn't support nested class properties, but is otherwise functional. I would like to request that it be added back in. It can be improved or replaced once there is something to replace it with, instead of just removing functionality.