networkx: fix subgraph and degree #14390
Open
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, |
|
Diff from mypy_primer, showing the effect of this PR on open source code: bokeh (https://github.com/bokeh/bokeh)
+ src/bokeh/models/util/structure.py:165: note: ... from here:
|
srittau
requested changes
Jul 10, 2025
| @overload | ||
| def __call__(self, nbunch: _Node, weight: None | bool | str = None) -> int: ... | ||
| @overload | ||
| def __call__(self, nbunch: Iterable[_Node] | None = None, weight: None | bool | str = None) -> DiDegreeView[_Node]: ... |
There was a problem hiding this comment.
Probably overly pedantic, but this doesn't necessarily return a DiDegreeView, but could also return a sub-class if called on an instance of a sub-class. So Self is more appropriate:
Suggested change
| def __call__(self, nbunch: Iterable[_Node] | None = None, weight: None | bool | str = None) -> DiDegreeView[_Node]: ... | |
| def __call__(self, nbunch: Iterable[_Node] | None = None, weight: None | bool | str = None) -> Self: ... |
| @@ -55,7 +55,10 @@ class NodeDataView(AbstractSet[_Node]): | |||
|
|
|||
| class DiDegreeView(Generic[_Node]): | |||
| def __init__(self, G: Graph[_Node], nbunch: _NBunch[_Node] = None, weight: None | bool | str = None) -> None: ... | |||
| def __call__(self, nbunch: _NBunch[_Node] = None, weight: None | bool | str = None) -> int | DiDegreeView[_Node]: ... | |||
| @overload | |||
| def __call__(self, nbunch: _Node, weight: None | bool | str = None) -> int: ... | |||
There was a problem hiding this comment.
__getitem__ returns float, so this should also return float:
Suggested change
| def __call__(self, nbunch: _Node, weight: None | bool | str = None) -> int: ... | |
| def __call__(self, nbunch: _Node, weight: None | bool | str = None) -> float: ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small fixes to
networkx, let me know if it's better with separate PRs:Graph.subgraphcan also take a single node.degreetakes a single node, the return type is different so addoverloads.