-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Lupa stubs: #14359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmarianer
wants to merge
4
commits into
python:main
Choose a base branch
from
jmarianer:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57
−40
Open
Lupa stubs: #14359
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# These are type aliases and not real objects | ||
lupa.lua51.LuaKey | ||
lupa.lua51.LuaObject | ||
lupa.lua52.LuaKey | ||
lupa.lua52.LuaObject | ||
lupa.lua53.LuaKey | ||
lupa.lua53.LuaObject | ||
lupa.lua54.LuaKey | ||
lupa.lua54.LuaObject |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
from _typeshed import MaybeNone | ||
from collections.abc import Callable, Iterator | ||
from collections.abc import Callable, Iterable | ||
from typing import Any, Final, Generic, TypeVar, type_check_only | ||
from typing_extensions import TypeAlias | ||
|
||
__all__ = [ | ||
"LUA_VERSION", | ||
|
@@ -34,15 +35,17 @@ unpacks_lua_table_method: Callable[[Callable[..., Any]], Callable[..., Any]] | |
|
||
# inner classes | ||
|
||
@type_check_only | ||
class _LuaIter: | ||
def __iter__(self) -> Iterator[object]: ... | ||
|
||
@type_check_only | ||
class _LuaTable: | ||
def keys(self) -> _LuaIter: ... | ||
def values(self) -> _LuaIter: ... | ||
def items(self) -> _LuaIter: ... | ||
def keys(self) -> Iterable[LuaKey]: ... | ||
def values(self) -> Iterable[LuaObject]: ... | ||
def items(self) -> Iterable[tuple[LuaKey, LuaObject]]: ... | ||
def __getitem__(self, key: LuaKey) -> LuaObject: ... | ||
def __setitem__(self, key: LuaKey, value: LuaObject) -> None: ... | ||
def __delitem__(self, key: LuaKey) -> None: ... | ||
|
||
LuaKey: TypeAlias = str | int | ||
LuaObject: TypeAlias = _LuaTable | int | str | float | bool | None | ||
|
||
@type_check_only | ||
class _LuaNoGC: ... | ||
|
@@ -70,8 +73,7 @@ class LuaRuntime: | |
lua_implementation: Final[str] | ||
lua_version: Final[tuple[int, int]] | ||
|
||
# @classmethod | ||
# def __cinit__(cls, unpack_return_tuples: bool) -> None: ... | ||
def __init__(self, /, unpack_returned_tuples: bool, *args: Any) -> None: ... | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please note that we need a comment for each |
||
# def add_pending_unref(self, ref: int) -> None: ... | ||
# def clean_up_pending_unrefs(self) -> int: ... | ||
def get_max_memory(self, total: bool = False) -> int | MaybeNone: ... | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand, these are not available at runtime, so we need to preface them with an underscore.
You could also consider adding a
lupa._types
modules where you define these type-check only items and just import them, but that's just an option.