[gdb] Complete stubs for gdb.dap
#14269
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
requested changes
Jul 7, 2025
| moduleId: NotRequired[str | None] | ||
| source: NotRequired[Source] | ||
|
|
||
| class _StaceTraceResult(TypedDict): |
There was a problem hiding this comment.
Just to verify: Should this be annotated with @type_check_only as well?
Comment on lines
+8
to
+9
| def read_json(stream: BinaryIO) -> Any: ... # returns result of json.loads | ||
| def start_json_writer(stream: BinaryIO, queue: DAPQueue[_JSONValue]) -> gdb.Thread: ... |
There was a problem hiding this comment.
Can we use a protocol (potentially an already existing one from _typeshed) instead of the semi-deprecated BinaryIO here?
| from _typeshed import Incomplete, Unused | ||
| from collections.abc import Callable | ||
| from contextlib import AbstractContextManager | ||
| from typing import Any, BinaryIO, Generic, TypeVar, type_check_only |
Comment on lines
+11
to
+22
| @type_check_only | ||
| class ValueFormat(TypedDict, total=False): | ||
| hex: bool | ||
|
|
||
| @type_check_only | ||
| class ReferenceDescriptor(TypedDict): | ||
| # Result of BaseReference.to_object() | ||
| variableReference: int | ||
| name: NotRequired[str] | ||
|
|
||
| @type_check_only | ||
| class VariableReferenceDescriptor(ReferenceDescriptor): |
There was a problem hiding this comment.
If they are type check only, their names should start with an underscore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fill in stubs for
gdb.dap, originally introduced in #12804.Based on gdb sources at the tag
gdb-15.2-release.(PEP 764 would have been reeeally nice here)