Add protected pprint.PrettyPrinter methods #14228
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added more protected methods
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Jul 7, 2025
Comment on lines
+114
to
+116
| def _format( | ||
| self, object: object, stream: IO[str], indent: int, allowance: int, context: dict[int, int], level: int | ||
| ) -> None: ... |
There was a problem hiding this comment.
IO is generally not recommended to use in argument annotations. From looking at the code, only write() seems to be called on the stream, so SupportsWrite (from _typeshed) seems like a suitable replacement.
Affects the methods below as well.
Comment on lines
+148
to
+150
| def _readable(self, object: object, context: dict[int, int]) -> bool: ... | ||
| def _recursive(self, object: object, context: dict[int, int]) -> bool: ... | ||
| def _depth(self, object: object, context: dict[int, int]) -> int: ... |
There was a problem hiding this comment.
These seem to be attributes, not methods.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protected method types are needed for sub-classing support. Else mypy complains like:
"PrettyPrinter" has no attribute "_format_dict_items".