Skip to content

PEP 799: A dedicated profilers module for organizing Python profiling tools #4504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 24, 2025
Merged

PEP 799: A dedicated profilers module for organizing Python profiling tools #4504

merged 11 commits into from
Jul 24, 2025

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 21, 2025 •
edited by github-actions bot
Loading

📚 Documentation preview 📚: https://pep-previews--4504.org.readthedocs.build/

@pablogsal pablogsal requested a review from a team as a code owner July 21, 2025 10:54
@AA-Turner AA-Turner changed the title PEP 795: A dedicated profilers module for organizing python profiling tools PEP 799: A dedicated profilers module for organizing python profiling tools Jul 21, 2025
@AA-Turner
Copy link
Member

799 is the next free number, I've updated accordingly.

A

@pablogsal
Copy link
Member Author

799 is the next free number, I've updated accordingly.

A

Thanks a lot! Will fix the linting errors today !

AA-Turner
AA-Turner requested changes Jul 21, 2025
View reviewed changes
@AA-Turner AA-Turner added the new-pep A new draft PEP submitted for initial review label Jul 21, 2025
@AA-Turner
Copy link
Member

Submitted too early -- @pablogsal my overarching comments were going to be a suggestion to use the :mod:`...` syntax throughout, and that as far as I understand it profile.sample is effectively a temporary name, so I think it would make more sense to reference it less -- no official release has contained profile.sample, so no users can be affected by renaming it.

A

@AA-Turner AA-Turner changed the title PEP 799: A dedicated profilers module for organizing python profiling tools PEP 799: A dedicated profilers module for organizing Python profiling tools Jul 21, 2025
hugovk
hugovk reviewed Jul 22, 2025
View reviewed changes
AA-Turner
AA-Turner reviewed Jul 22, 2025
View reviewed changes
@pablogsal
Copy link
Member Author

I am going to go ahead and land this. We can fix small things afterwards. Thanks a lot @AA-Turner, @alex and @hugovk for all the help!

@pablogsal pablogsal enabled auto-merge (squash) July 24, 2025 17:17
AA-Turner
AA-Turner requested changes Jul 24, 2025
View reviewed changes
@pablogsal @AA-Turner
Update peps/pep-0799.rst
e3ba117 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@pablogsal pablogsal disabled auto-merge July 24, 2025 17:26
@pablogsal pablogsal enabled auto-merge (squash) July 24, 2025 17:26
@pablogsal pablogsal merged commit 9cd84a7 into python:main Jul 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@AA-Turner AA-Turner AA-Turner requested changes

Assignees
No one assigned
Labels
new-pep A new draft PEP submitted for initial review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablogsal @AA-Turner @hugovk