PEP 791: address PEP review comments #4430
Conversation
skirpichev
force-pushed
the
pep791-address-comments
branch
2 times, most recently
from
963f154 to
86e15a2
Compare
* add submodule variant
skirpichev
force-pushed
the
pep791-address-comments
branch
from
86e15a2 to
8cdce7a
Compare
|
CC @zooba |
| Which content, as in beginning, will be again related to work with "just | ||
| numbers" --- that for most people with basic education means some model of real | ||
| numbers). |
There was a problem hiding this comment.
This feels dismissive, can we reword it?
There was a problem hiding this comment.
Any suggestions?
I meant we can't expect advanced math background from average Python users. What they might expect from "just numbers"? They are closed for arithmetic operations (python's int's - aren't), but sometimes not for algebraic (e.g. sqrt(-1)), and they are more than just rational numbers (i.e. sqrt(2)). People also probably aware of decimal floating-point model for real numbers (or at least with fixed-point).
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
| @@ -131,6 +156,10 @@ interval math or numerical integration. | |||
| Other proposed names include ``ntheory`` (like SymPy's submodule), | |||
| ``integermath`` and ``imaths``. | |||
|
|
|||
| As a variant, the new module can be added as a submodule of the | |||
| :external+py3.14:mod:`math`. The main module itself will preserve a "catch-all" | |||
There was a problem hiding this comment.
I am not convinced by the "catch all" aspect knowing that cmath and statistics will stay outside the math package.
There was a problem hiding this comment.
This naming suggests, that new functions (that are not suitable for cmath/statistics/random) will go either to the math module or to some math's submodule.
I think it's an important implication of this naming scheme, i.e. we can't just drop this sentence. But I appreciate any suggestions to reword it.
PEP 123: Summary of changes)📚 Documentation preview 📚: https://pep-previews--4430.org.readthedocs.build/pep-0791/