-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
PEP 788: Address feedback from first discussion round #4400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@godlygeek I can't add you as a reviewer, but I'd appreciate your opinion on some of the new things I'm proposing here. |
Bump @AA-Turner @vstinner now that the beta is out. There's no rush considering we have a year until the 3.15 freeze, though. |
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. I haven't gotten though the whole proposal, but did start by trying to understand what we're trying to solve here. I've left short notes for each of the motivation sections. Ultimately, I think are some bugs to be addressed separately and the other concerns could be solved without replacing the existing API. That doesn't mean a new API isn't warranted, but let's see how much value it would add first. (I'd be glad to hop into a call to discuss this more.)
That'd be great. Shoot me a message on Discord so we can figure something out. (Note that I'll have limited availability this week.) |
I think most of Eric's comments will fit better on the public discussion thread, so I didn't deal with them too much. @colesbury I've addressed most of your concerns. In particular, thread states and interpreter refs are now separate, so there's no more "non-daemon thread states." I'd appreciate your rubber-stamp before landing this, would you mind doing a quick once-over when you get a chance? |
Co-authored-by: Victor Stinner <vstinner@python.org>
I had to resolve many of the comments because it won't let us merge this while things are open. If there's anything that wasn't fully addressed, please bring it up on the thread! @vstinner, we're ready to go. |
I merged the PR, thanks. |
PEP 123: Summary of changes
)The key changes I made here are:
PyInterpreterRef
andPyInterpreterWeakRef *
).PyInterpreterState *
for refs).kept separate.
📚 Documentation preview 📚: https://pep-previews--4400.org.readthedocs.build/pep-0788/