Skip to content

Change links from typing.readthedocs.io to typing.python.org #4291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2025
Merged

Change links from typing.readthedocs.io to typing.python.org #4291

merged 3 commits into from
Mar 5, 2025

Conversation

srittau
Copy link
Contributor

@srittau srittau commented Mar 5, 2025 •
edited by github-actions bot
Loading

@srittau srittau mentioned this pull request Mar 5, 2025
Closed
4 tasks
@srittau
Copy link
Contributor Author

srittau commented Mar 5, 2025 •
edited
Loading

I've left historical links in PEPs alone, they are redirected to the new URL anyway.

hugovk
hugovk approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

AA-Turner
AA-Turner approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left historical links in PEPs alone, they are redirected to the new URL anyway.

We may as well update these, linkcheck will complain about redirects.

A

@AA-Turner AA-Turner merged commit b93c20f into python:main Mar 5, 2025
22 checks passed
@srittau srittau deleted the typing.python.org branch March 5, 2025 16:29
@srittau
Copy link
Contributor Author

srittau commented Mar 5, 2025

Sorry for the broken formatting. I thought I had successfully told VSCode to leave formatting alone, unless explicitly configured. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@carljm carljm Awaiting requested review from carljm carljm is a code owner

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja hauntsaninja is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srittau @hugovk @AA-Turner