Skip to content

Switch over to Codecov v5 #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Jun 11, 2025

This is a debug PR, I don't want to clutter up #3161

@A5rocks A5rocks marked this pull request as draft June 11, 2025 15:35
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00000%. Comparing base (8571ef2) to head (a31d536).

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3285   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             127          125    -2     
  Lines           19266        19250   -16     
  Branches         1301         1301           
===============================================
- Hits            19266        19250   -16     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@A5rocks
Copy link
Contributor Author

A5rocks commented Jun 11, 2025

Spotted:

  • It seems to be using the wrong path for Alpine (it includes the full path including the .venv)
  • It seems to be ignoring our specified coverage ignore lines

@A5rocks
Copy link
Contributor Author

A5rocks commented Jun 11, 2025

First part is fixed

@A5rocks
Copy link
Contributor Author

A5rocks commented Jun 11, 2025

OK nevermind that fixes both issues, @webknjaz in case you want to copy these changes to your PR.

@A5rocks
Copy link
Contributor Author

A5rocks commented Jun 27, 2025

Turns out I can't modify that PR to add in a few commits. I guess codecov v5 isn't that urgent anyways though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant