Skip to content

async102 & async120 no longer requires cancelscope to have a timeout #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 7, 2025

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented May 6, 2025

fixes #272

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the linter is happy 🙂

@@ -4,6 +4,10 @@ Changelog

`CalVer, YY.month.patch <https://calver.org/>`_

25.5.2
======
- :ref:`ASYNC120 <async120>` no longer requires cancel scopes to have a timeout. https://github.com/python-trio/flake8-async/issues/272
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give the url some link text, e.g. (issue #272)

@jakkdl jakkdl changed the title async120 no longer requires cancelscope to have a timeout async102 & async120 no longer requires cancelscope to have a timeout May 7, 2025
@jakkdl
Copy link
Member Author

jakkdl commented May 7, 2025

2025-05-07T12:45:46,087293502+02:00
the test failure was some weird backend issue

@jakkdl
Copy link
Member Author

jakkdl commented May 7, 2025

prettified all urls in the changelog, and also noticed that one of them was pointing at the entirely wrong issue (may have been copypasted from previous entry)

@jakkdl jakkdl enabled auto-merge (squash) May 7, 2025 10:49
@jakkdl jakkdl merged commit ebe7e97 into python-trio:main May 7, 2025
9 of 10 checks passed
@jakkdl jakkdl deleted the async120_false_alarm branch May 7, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASYNC120: unintuitive error message
2 participants