-
-
Notifications
You must be signed in to change notification settings - Fork 71
Improve French translation #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
merwok
commented
Apr 1, 2025
- fix number units translations
- use proper decimal separator
@@ -119,257 +119,247 @@ msgctxt "9 (female)" | |||
msgid "th" | |||
msgstr "e" | |||
|
|||
#: src/humanize/number.py:178 | |||
#: src/humanize/number.py:183 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my own projects, I tend to save filenames but not line numbers to PO files, to avoid such diff churn.
What do you think of changing the update script in another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't make translations myself, so if they're not useful I'll take your word for it and a PR is welcome :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either the line numbers get outdated, so they are useless and get ignored, or they create churn in the history (which I could just accept but…)
So personally I find the filenames useful to be able to look up the context (source strings and even context lines from pgettext are not always enough), I tend to dislike the line numbers.
But you could open a ticket and ping translators to see their experience!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 11 11
Lines 796 798 +2
=======================================
+ Hits 792 794 +2
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merci beaucoup ! |