Skip to content

Update sir-lancebot to Python 3.13 #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 19, 2025
Merged

Update sir-lancebot to Python 3.13 #1670

merged 3 commits into from
Apr 19, 2025

Conversation

wookie184
Copy link
Contributor

@wookie184 wookie184 commented Apr 8, 2025 •
edited
Loading

On merge todo:

  • Update site
  • Update repo topics
  • Post announcement

@python-discord-policy-bot python-discord-policy-bot bot requested a review from a team April 8, 2025 12:01
wookie184 added a commit to python-discord/site that referenced this pull request Apr 8, 2025
@wookie184
Update sir-lancebot Python version
5e20d90 
For after python-discord/sir-lancebot#1670
@wookie184 wookie184 mentioned this pull request Apr 8, 2025
Merged
@wookie184 wookie184 added area: dependencies Related to package dependencies and management status: needs review Author is waiting for someone to review and approve type: enhancement Changes or improvements to existing features labels Apr 8, 2025
ChrisLovering
ChrisLovering approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@ChrisLovering ChrisLovering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great locally too!

jchristgit
jchristgit approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good from a quick glance. Did not review poetry.lock. Thanks!

@wookie184 wookie184 merged commit 1bb852d into main Apr 19, 2025
5 checks passed
@wookie184 wookie184 deleted the python-313-upgrade branch April 19, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLovering ChrisLovering ChrisLovering approved these changes

@jchristgit jchristgit jchristgit approved these changes

Assignees
No one assigned
Labels
area: dependencies Related to package dependencies and management status: needs review Author is waiting for someone to review and approve type: enhancement Changes or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wookie184 @ChrisLovering @jchristgit