Remove pings when auto-banning in filters #3306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaruh
requested changes
Mar 30, 2025
bot/exts/filtering/filtering.py
Outdated
| # If the action is a ban, mods don't want to be pinged. | ||
| if infr_action := result_actions.get("infraction_and_notification"): | ||
| if infr_action.infraction_type == Infraction.BAN: | ||
| del result_actions["mentions"] |
There was a problem hiding this comment.
What if there are no mentions?
Suggested change
| del result_actions["mentions"] | |
| result_actions.pop("mentions", None) |
Mods no longer want to be pinged when a fitler results in an auto ban, but we still want the message to be sent to mod-alerts.
ChrisLovering
force-pushed
the
remove-ping-on-auto-ban
branch
from
de418f6 to
72e8fe9
Compare
Jayy001
approved these changes
Mar 31, 2025
mbaruh
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mods no longer want to be pinged when a fitler results in an auto ban, but we still want the message to be sent to mod-alerts.