Skip to content

Add support for Python 3.14 and remove support for Python 3.8 #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2025
Merged

Add support for Python 3.14 and remove support for Python 3.8 #1419

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6eddbdd
Add support for Python 3.14 and remove support for Python 3.8
tleonhardt May 22, 2025
e8e221f
Try to fix unit tests for Python 3.14
tleonhardt May 22, 2025
b597343
Fix tests failing on Windows for Python 3.14
tleonhardt May 22, 2025
7420eda
Improved a few tests to be slightly stricter, but permissive enough t…
tleonhardt May 22, 2025
b6e656b
Enable some additional ruff lint check rules and enable auto-fix of l…
tleonhardt May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 40 additions & 14 deletions cmd2/argparse_custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,6 +1252,9 @@ def __init__(
conflict_handler: str = 'error',
add_help: bool = True,
allow_abbrev: bool = True,
exit_on_error: bool = True,
suggest_on_error: bool = False,
color: bool = False,
*,
ap_completer_type: Optional[Type['ArgparseCompleter']] = None,
) -> None:
Expand All @@ -1262,20 +1265,43 @@ def __init__(
behavior on this parser. If this is None or not present, then cmd2 will use
argparse_completer.DEFAULT_AP_COMPLETER when tab completing this parser's arguments
"""
super(Cmd2ArgumentParser, self).__init__(
prog=prog,
usage=usage,
description=description,
epilog=epilog,
parents=parents if parents else [],
formatter_class=formatter_class, # type: ignore[arg-type]
prefix_chars=prefix_chars,
fromfile_prefix_chars=fromfile_prefix_chars,
argument_default=argument_default,
conflict_handler=conflict_handler,
add_help=add_help,
allow_abbrev=allow_abbrev,
)
# TODO: CHANGE so if Python >= 3.14 new args are passed
if sys.version_info[1] >= 14:
# Python >= 3.14 so pass new arguments to parent argparse.ArgumentParser class
super(Cmd2ArgumentParser, self).__init__(
prog=prog,
usage=usage,
description=description,
epilog=epilog,
parents=parents if parents else [],
formatter_class=formatter_class, # type: ignore[arg-type]
prefix_chars=prefix_chars,
fromfile_prefix_chars=fromfile_prefix_chars,
argument_default=argument_default,
conflict_handler=conflict_handler,
add_help=add_help,
allow_abbrev=allow_abbrev,
exit_on_error=exit_on_error,
suggest_on_error=suggest_on_error,
color=color,
)
else:
# Python < 3.14, so don't pass new arguments to parent argparse.ArgumentParser class
super(Cmd2ArgumentParser, self).__init__(
prog=prog,
usage=usage,
description=description,
epilog=epilog,
parents=parents if parents else [],
formatter_class=formatter_class, # type: ignore[arg-type]
prefix_chars=prefix_chars,
fromfile_prefix_chars=fromfile_prefix_chars,
argument_default=argument_default,
conflict_handler=conflict_handler,
add_help=add_help,
allow_abbrev=allow_abbrev,
exit_on_error=exit_on_error,
)

self.set_ap_completer_type(ap_completer_type) # type: ignore[attr-defined]

Expand Down
Loading