Skip to content

chore: Rust toolchain/CI update and workspace setup #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025

Conversation

Riateche
Copy link
Contributor

@Riateche Riateche commented Jul 2, 2025

Summary

  • Added top level Cargo workspace and rust-toolchain.toml file
  • Updated all Rust CI actions to use rust-toolchain.toml file instead of hardcoding version in the action
  • Updated all Rust CI actions to use actions-rust-lang/setup-rust-toolchain
  • Removed redundant Swatinem/rust-cache as the above action calls it internally
  • Removed rust-toolchain files so that the top level version is used where possible
  • Enabled new lints for a few projects

Smart contracts remain in their separate workspaces. There are a couple of reasons why they cannot be included in the main workspace (pinned dependencies, lack of chain tooling support, different release profile configs).

Rationale

  • It's easier to upgrade toolchain for all projects.
  • It's easier to maintain projects if they're built/checked using a recent Rust toolchain.
  • Now it's easier to add new projects to the shared workspace.
  • Better Rust tooling support (e.g. rust-analyzer).

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

Copy link

vercel bot commented Jul 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 9:55am
component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 9:55am
developer-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 9:55am
entropy-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 9:55am
entropy-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 9:55am
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 9:55am
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 9:55am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 9:55am

Copy link
Collaborator

@ali-behjati ali-behjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@@ -0,0 +1,3 @@
allow-unwrap-in-tests = true
allow-expect-in-tests = true
#allow-indexing-slicing-in-tests = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants