improve tracing coverage #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reisen
approved these changes
Jul 15, 2024
ali-behjati
reviewed
Jul 15, 2024
ali-behjati
reviewed
Jul 15, 2024
ali-behjati
reviewed
Jul 16, 2024
config/config.sample.pythtest.toml
Outdated
| @@ -60,3 +60,12 @@ exporter.compute_unit_price_micro_lamports = 1000 | |||
| # Note that this doesn't affect the rate at which transactions are published: | |||
There was a problem hiding this comment.
let's hide it from sample files for the time being.
There was a problem hiding this comment.
im assuming you mean the opentelemetry config?
ali-behjati
reviewed
Jul 16, 2024
ali-behjati
reviewed
Jul 16, 2024
ali-behjati
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances tracing by introducing the
#[instrument]macro to more functions and adding additional fields to the current span inget_product.rs,subscribe_price.rs, andsubscribe_price_sched.rs. This approach is async safe as it maintains the reference to the current span without manual enter/exit, ensuring the tracing context is preserved across await points. We should avoid manual enter/exit tracing logs already handled by#[instrument], and any custom spans should be cautious of this behavior to avoid manual span entry.