feat: add minimum platform fees #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
danimhr
reviewed
Jul 2, 2025
| } | ||
| }); | ||
|
|
||
| match (fee_user, fee_searcher) { |
There was a problem hiding this comment.
fee_user .into_iter() .chain(fee_searcher) .max()
| None | ||
| } | ||
| }); | ||
| let fee_searcher = self.minimum_platform_fee_list.iter().find_map(|fee| { |
There was a problem hiding this comment.
let fee_searcher = self
.minimum_platform_fee_list
.iter()
.find(|fee| &fee.mint == mint_searcher)
.map(|fee| fee.fee_ppm);
I feel using find and then map is a better approach. But your choice
| @@ -7,7 +7,7 @@ repository = "https://github.com/pyth-network/per" | |||
| license = "Apache-2.0" | |||
|
|
|||
| [dependencies] | |||
| express-relay-api-types = { version = "0.12.0", path = "../../auction-server/api-types" } | |||
| express-relay-api-types = { version = "0.12.1", path = "../../auction-server/api-types" } | |||
There was a problem hiding this comment.
We also need to update the "express-relay-client" version
danimhr
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a minimum platform fees list to the config and parses it to apply platform fees based on token mints.
In order to release this feature, we need to
swap_v2instead ofswapplatform_fee_ppmthereLonger term, we ought to