Skip to content

Lazer doc updates #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Lazer doc updates #569

merged 2 commits into from
Jan 16, 2025

Conversation

jayantk
Copy link
Contributor

@jayantk jayantk commented Jan 16, 2025

Description

I ran through these instructions and fixed a couple bugs. I also improved wording in a few places.

Type of Change

  • New Page
  • Page update/improvement
  • Fix typo/grammar
  • Restructure/reorganize content
  • Update links/references
  • Other (please describe):

Areas Affected

Lazer

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 7:52pm
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 7:52pm

@@ -2,12 +2,12 @@ import { Callout, Steps } from "nextra/components";

# How to Subscribe to Price Updates from Pyth Lazer

This guide explains how to subscribe to price updates from Pyth Lazer. This guide will also explain various properties and channels that one can use to customize the price updates.
This guide explains how to subscribe to price updates from Pyth Lazer. This guide will also explain various properties and configuration options to customize the price updates.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "one" wording in this doc was weird. I made everything imperative.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I tried not to use personal "You" and "your" initially.

const client = new PythLazerClient(
"wss://pyth-lazer.dourolabs.app/v1/stream",
"ctoken1"
const client = await PythLazerClient.create(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the SDK interface changed since this was written

(by the way the example is wrong now as well)

@jayantk jayantk merged commit 8aeb8ca into main Jan 16, 2025
5 checks passed
@jayantk jayantk deleted the lazer branch January 16, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants