feat(entropy): More best practices #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aditya520
approved these changes
Jun 12, 2024
pages/entropy/best-practices.mdx
Outdated
| Since the entropy providers limit the gas usage on the callbacks, | ||
| it is important to keep the callback function as simple as possible | ||
| so that the gas usage is predictable and below the limits. | ||
| This will ensure consistent performance and avoid potential issues with the callback. |
There was a problem hiding this comment.
This first paragraph can be rephrased like
Keeping the callback function simple is crucial because the entropy providers limit gas usage. This ensures gas usage is predictable and consistent, avoiding potential issues with the callback.
jayantk
reviewed
Jun 12, 2024
pages/entropy/best-practices.mdx
Outdated
| either ask users to submit more transactions after the callback to continue the flow or run a background crank service | ||
| to submit the necessary transactions. | ||
|
|
||
| You can see the gas limits for each chain in [this](./contract-addresses) page. |
There was a problem hiding this comment.
I suggest linking to pages using the page title, so like "The gas limits for each chain are listed on the Contract Addresses page."
that way the reader can find this info from the index if they're looking for it later.
m30m
force-pushed
the
more-best-practices
branch
from
6f84c70 to
9f03689
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.